| commit | 7b6ab410b0665dcb84c2818f4453b36f2c5a1e36 | |
| author | jamiewalch <jamiewalch@chromium.org> | |
| Mon, 2 Mar 2015 23:11:39 +0000 (2 15:11 -0800) | ||
| committer | Commit bot <commit-bot@chromium.org> | |
| Mon, 2 Mar 2015 23:12:19 +0000 (2 23:12 +0000) | ||
| tree | 015464cd9f7f1fb40b2f61c3ea350b5e6849c47c | treesnapshot (tar.gz zip) |
| parent | 3b0ed8bb4f9d4e72a4f0816fd37ca68828da5135 | commitdiff |
Remove getCached* methods from remoting.Identity.
These methods were introduced before Promises were implemented to simplify
code that just needs an email address but wouldn't otherwise need to be
written asynchronously. With Promises, asynchronous code reads a lot more
naturally, and it's less of a concern.
Having explicit accessors for cached state means that there needs to be
some (asynchronous) initialization code to save them, which complicates
some of the changes I'm planning on making to application start-up. The
simplest fix is eliminate them altogether and make all the call-sites
asynchronous.
Review URL: https://codereview.chromium.org/963103004
Cr-Commit-Position: refs/heads/master@{#318794}
These methods were introduced before Promises were implemented to simplify
code that just needs an email address but wouldn't otherwise need to be
written asynchronously. With Promises, asynchronous code reads a lot more
naturally, and it's less of a concern.
Having explicit accessors for cached state means that there needs to be
some (asynchronous) initialization code to save them, which complicates
some of the changes I'm planning on making to application start-up. The
simplest fix is eliminate them altogether and make all the call-sites
asynchronous.
Review URL: https://codereview.chromium.org/963103004
Cr-Commit-Position: refs/heads/master@{#318794}