| commit | 7a8e9e88cfb9b35da87cf2b1bc2e22cdfae36540 | |
| author | msw@chromium.org <msw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Thu, 31 Jul 2014 17:18:21 +0000 (31 17:18 +0000) | ||
| committer | msw@chromium.org <msw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Thu, 31 Jul 2014 17:18:21 +0000 (31 17:18 +0000) | ||
| tree | 72e4617b6dcd6dc1b7c45ea9d854ca91aef01ac8 | treesnapshot (tar.gz zip) |
| parent | 8323cbd534b29298cb50940354341c6fd2a48ca8 | commitdiff |
Fix views Label and BookmarkButtonBase tooltip behavior.
Make BookmarkButtonBase handle tooltips, not child views.
(it will supersede its own Label and ImageView tooltips)
Only show height-overflow tooltips for multi-line Labels.
(single-line Labels only show tooltips for width overflow)
Add a LabelTest.TooltipProperty check for this case.
BUG=398333
TEST=Bookmark buttons show mutli-line title/url tooltips.
R=sky@chromium.org
Review URL: https://codereview.chromium.org/414183005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@286839 0039d316-1c4b-4281-b951-d872f2087c98
Make BookmarkButtonBase handle tooltips, not child views.
(it will supersede its own Label and ImageView tooltips)
Only show height-overflow tooltips for multi-line Labels.
(single-line Labels only show tooltips for width overflow)
Add a LabelTest.TooltipProperty check for this case.
BUG=398333
TEST=Bookmark buttons show mutli-line title/url tooltips.
R=sky@chromium.org
Review URL: https://codereview.chromium.org/414183005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@286839 0039d316-1c4b-4281-b951-d872f2087c98
| chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc | diffblobblamehistory | |
| ui/views/controls/label.cc | diffblobblamehistory | |
| ui/views/controls/label_unittest.cc | diffblobblamehistory |