Turn UserContext into a class with explicit getters and setters
commit7a61377589cc2a20af5dcffcfe0df723f6da31fb
authorbartfab@chromium.org <bartfab@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Thu, 15 May 2014 16:39:36 +0000 (15 16:39 +0000)
committerbartfab@chromium.org <bartfab@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Thu, 15 May 2014 16:39:36 +0000 (15 16:39 +0000)
treeaa6a5c2ea029c03d8045582480f389ffda8fd443
parentbcd825d38b70d2ccd873fc28a6f41c3ba89d8504
Turn UserContext into a class with explicit getters and setters

Until now, UserContext was a struct with public members. This led to code
manipulating the UserContext state in ways that were impossible to keep
track of.

This CL is a first step toward making UserContext more robust. Right now,
many places in the code make copies of a UserContext by calling one of the
UserContext constructors. These constructors copy only a subset of the
state. It is never clear whether such partial copies are intentional or
accidental. A follow-up CL will address this by adjusting each place where
a copy of a UserContext is made.

BUG=367847
TEST=Updated browser and unit tests

TBR=xiyuan (chrome/browser/chromeos/app_mode/kiosk_profile_loader.cc)
TBR=pamg (chrome/browser/managed_mode/chromeos/manager_password_service.cc)

Review URL: https://codereview.chromium.org/280883004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270689 0039d316-1c4b-4281-b951-d872f2087c98
27 files changed:
chrome/browser/chromeos/app_mode/kiosk_profile_loader.cc
chrome/browser/chromeos/login/auth_attempt_state.cc
chrome/browser/chromeos/login/authenticator.h
chrome/browser/chromeos/login/existing_user_controller.cc
chrome/browser/chromeos/login/extended_authenticator.cc
chrome/browser/chromeos/login/fake_login_utils.cc
chrome/browser/chromeos/login/login_performer.cc
chrome/browser/chromeos/login/login_status_consumer.h
chrome/browser/chromeos/login/login_utils.cc
chrome/browser/chromeos/login/login_utils.h
chrome/browser/chromeos/login/managed/managed_user_creation_controller_new.cc
chrome/browser/chromeos/login/managed/supervised_user_authentication.cc
chrome/browser/chromeos/login/managed/supervised_user_authentication.h
chrome/browser/chromeos/login/managed/supervised_user_login_flow.cc
chrome/browser/chromeos/login/mock_authenticator.cc
chrome/browser/chromeos/login/mock_login_utils.h
chrome/browser/chromeos/login/online_attempt.cc
chrome/browser/chromeos/login/online_attempt_host.cc
chrome/browser/chromeos/login/online_attempt_host.h
chrome/browser/chromeos/login/parallel_authenticator.cc
chrome/browser/chromeos/login/screen_locker.cc
chrome/browser/chromeos/login/test_login_utils.cc
chrome/browser/chromeos/login/user.cc
chrome/browser/chromeos/login/user.h
chrome/browser/chromeos/login/webui_screen_locker.h
chrome/browser/managed_mode/chromeos/manager_password_service.cc
chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h