| commit | 7a29561b1bf022324bf3533a0dd9183e00061028 | |
| author | droger@chromium.org <droger@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Mon, 17 Feb 2014 17:06:12 +0000 (17 17:06 +0000) | ||
| committer | droger@chromium.org <droger@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Mon, 17 Feb 2014 17:06:12 +0000 (17 17:06 +0000) | ||
| tree | d98df4f76c7797c049d5a595011da6a9e8763a21 | treesnapshot (tar.gz zip) |
| parent | 3051f1ce5b0537c5648b6941b95a2832702eb245 | commitdiff |
Refactor TranslateManager::Observer to not assume that TranslateManager is a singleton
The TranslateManager::Observer list was global and owned by TranslateManager.
It has been split in two:
- the language detection events are no longer handled by TranslateManager ;
the single observer for this (TranslateInternalsHandler) now directly observes the notifications
- the translate error events are still managed by TranslateManager but use
a global observer list (which is now actually a callback list) and are no longer handled by the TranslateManager singleton instance.
BUG=332736
Review URL: https://codereview.chromium.org/166403003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251688 0039d316-1c4b-4281-b951-d872f2087c98
The TranslateManager::Observer list was global and owned by TranslateManager.
It has been split in two:
- the language detection events are no longer handled by TranslateManager ;
the single observer for this (TranslateInternalsHandler) now directly observes the notifications
- the translate error events are still managed by TranslateManager but use
a global observer list (which is now actually a callback list) and are no longer handled by the TranslateManager singleton instance.
BUG=332736
Review URL: https://codereview.chromium.org/166403003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251688 0039d316-1c4b-4281-b951-d872f2087c98