| commit | 79359cecd0ce534e356e3380a4d7e4dc4a29e07b | |
| author | ananta <ananta@chromium.org> | |
| Tue, 9 Sep 2014 05:45:40 +0000 (8 22:45 -0700) | ||
| committer | Commit bot <commit-bot@chromium.org> | |
| Tue, 9 Sep 2014 05:47:31 +0000 (9 05:47 +0000) | ||
| tree | 8859f5e98e802aae1dbf640d3d9c64f810835f7c | treesnapshot (tar.gz zip) |
| parent | a3e727222442a84542c508bf9b436691a217e08d | commitdiff |
Fix a crash which occurs while translating the windows message WM_DEADCHAR to our events format.
The crash occurs because the EventTypeFromNative helper function on windows does not handle this
message and returns ET_UNKNOWN as the type leading to a CHECK later on. The WM_DEADCHAR message
is posted while translating certain character sequences in the context of WM_KEYUP.
Fix is to return the type for WM_DEADCHAR as ET_KEY_RELEASED.
BUG=411811
Review URL: https://codereview.chromium.org/551863003
Cr-Commit-Position: refs/heads/master@{#293859}
The crash occurs because the EventTypeFromNative helper function on windows does not handle this
message and returns ET_UNKNOWN as the type leading to a CHECK later on. The WM_DEADCHAR message
is posted while translating certain character sequences in the context of WM_KEYUP.
Fix is to return the type for WM_DEADCHAR as ET_KEY_RELEASED.
BUG=411811
Review URL: https://codereview.chromium.org/551863003
Cr-Commit-Position: refs/heads/master@{#293859}
| ui/events/win/events_win.cc | diffblobblamehistory |