Revert of cc: Remove use of PassAs() and constructor-casting with scoped_ptr. (patchs...
commit78d5331bcd375f8c8f0285d648dc30cc4f206367
authordcheng <dcheng@chromium.org>
Sat, 27 Sep 2014 07:33:06 +0000 (27 00:33 -0700)
committerCommit bot <commit-bot@chromium.org>
Sat, 27 Sep 2014 07:33:30 +0000 (27 07:33 +0000)
treeafc3c9100269d4dab67803ed9650f4a4d6baba23
parent67f01ddf1bc44927cbe10bcc000bf8eec462c1fc
Revert of cc: Remove use of PassAs() and constructor-casting with scoped_ptr. (patchset #6 id:120001 of https://codereview.chromium.org/609663003/)

Reason for revert:
scoped_ptr nullptr support needs to be reverted

Original issue's description:
> cc: Remove use of PassAs() and constructor-casting with scoped_ptr.
>
> Say you have class A and subclass B.
>
> Previously it was required to PassAs() a scoped_ptr<B> into a
> scoped_ptr<A>. This is no longer needed, so just use Pass(). For newly
> created scoped_ptrs, you can just use make_scoped_ptr always now.
>
> And when you want to return or assign an empty scoped_ptr(), you can
> now use nullptr directly.
>
> Also adds PRESUBMIT checks for:
> - return scoped<T>(foo). This should be return make_scoped_ptr(foo).
> - bar = scoped<T>(foo). This should be return bar = make_scoped_ptr(foo).
> - return scoped<T>(). This should be return nullptr.
> - bar = scoped<T>(). This should be return bar = nullptr.
>
> This also replaces p.reset() with p = nullptr; But it does not add a
> PRESUBMIT check for that because there are things other than scoped_ptr
> with a reset() function.
>
> R=enne@chromium.org
>
> Committed: https://crrev.com/7bb3dbede19d87f0338797756ffd738adc6bca08
> Cr-Commit-Position: refs/heads/master@{#297096}

TBR=enne@chromium.org,jamesr@chromium.org,vmpstr@chromium.org,danakj@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/608503005

Cr-Commit-Position: refs/heads/master@{#297106}
124 files changed:
cc/PRESUBMIT.py
cc/animation/animation_unittest.cc
cc/animation/keyframed_animation_curve.cc
cc/animation/keyframed_animation_curve_unittest.cc
cc/animation/layer_animation_controller_unittest.cc
cc/animation/scroll_offset_animation_curve.cc
cc/animation/timing_function.cc
cc/base/math_util.cc
cc/base/region.cc
cc/base/scoped_ptr_vector.h
cc/blink/web_animation_curve_common.cc
cc/blink/web_filter_animation_curve_impl.cc
cc/blink/web_float_animation_curve_impl.cc
cc/blink/web_transform_animation_curve_impl.cc
cc/debug/micro_benchmark_controller.cc
cc/debug/micro_benchmark_controller_unittest.cc
cc/debug/picture_record_benchmark.cc
cc/debug/rasterize_and_record_benchmark.cc
cc/debug/rasterize_and_record_benchmark_impl.cc
cc/debug/unittest_only_benchmark.cc
cc/input/top_controls_manager.cc
cc/layers/content_layer.cc
cc/layers/delegated_renderer_layer.cc
cc/layers/delegated_renderer_layer_impl.cc
cc/layers/delegated_renderer_layer_impl_unittest.cc
cc/layers/heads_up_display_layer.cc
cc/layers/heads_up_display_layer_impl.cc
cc/layers/heads_up_display_layer_impl_unittest.cc
cc/layers/io_surface_layer.cc
cc/layers/io_surface_layer_impl.cc
cc/layers/layer.cc
cc/layers/layer_impl.cc
cc/layers/layer_impl_unittest.cc
cc/layers/layer_perftest.cc
cc/layers/layer_unittest.cc
cc/layers/nine_patch_layer.cc
cc/layers/nine_patch_layer_impl.cc
cc/layers/painted_scrollbar_layer.cc
cc/layers/painted_scrollbar_layer_impl.cc
cc/layers/picture_image_layer.cc
cc/layers/picture_image_layer_impl.cc
cc/layers/picture_image_layer_impl_unittest.cc
cc/layers/picture_layer.cc
cc/layers/picture_layer_impl.cc
cc/layers/picture_layer_impl_perftest.cc
cc/layers/picture_layer_impl_unittest.cc
cc/layers/solid_color_layer.cc
cc/layers/solid_color_layer_impl.cc
cc/layers/solid_color_scrollbar_layer.cc
cc/layers/solid_color_scrollbar_layer_impl.cc
cc/layers/surface_layer.cc
cc/layers/surface_layer_impl.cc
cc/layers/texture_layer.cc
cc/layers/texture_layer_impl.cc
cc/layers/texture_layer_unittest.cc
cc/layers/tiled_layer.cc
cc/layers/tiled_layer_impl.cc
cc/layers/tiled_layer_unittest.cc
cc/layers/ui_resource_layer.cc
cc/layers/ui_resource_layer_impl.cc
cc/layers/video_layer.cc
cc/layers/video_layer_impl.cc
cc/output/bsp_tree.cc
cc/output/delegating_renderer_unittest.cc
cc/output/gl_renderer.cc
cc/output/gl_renderer_unittest.cc
cc/output/output_surface_unittest.cc
cc/output/renderer_unittest.cc
cc/output/software_renderer.cc
cc/output/software_renderer_unittest.cc
cc/quads/draw_polygon.cc
cc/quads/render_pass_unittest.cc
cc/resources/bitmap_content_layer_updater.cc
cc/resources/bitmap_skpicture_content_layer_updater.cc
cc/resources/image_layer_updater.cc
cc/resources/picture.cc
cc/resources/prioritized_resource_unittest.cc
cc/resources/raster_worker_pool_unittest.cc
cc/resources/resource_provider.cc
cc/resources/resource_provider_unittest.cc
cc/resources/task_graph_runner_perftest.cc
cc/resources/texture_mailbox_deleter_unittest.cc
cc/resources/tile_manager_perftest.cc
cc/resources/tile_manager_unittest.cc
cc/resources/ui_resource_request.cc
cc/surfaces/surface_aggregator.cc
cc/test/animation_test_common.cc
cc/test/cc_test_suite.cc
cc/test/fake_content_layer.cc
cc/test/fake_content_layer_impl.cc
cc/test/fake_delegated_renderer_layer.cc
cc/test/fake_delegated_renderer_layer_impl.cc
cc/test/fake_layer_tree_host_client.cc
cc/test/fake_output_surface.cc
cc/test/fake_picture_layer.cc
cc/test/fake_picture_layer_impl.cc
cc/test/fake_tile_manager.cc
cc/test/layer_test_common.cc
cc/test/layer_test_common.h
cc/test/layer_tree_pixel_test.cc
cc/test/layer_tree_test.cc
cc/test/pixel_test.cc
cc/test/render_pass_test_utils.cc
cc/test/test_shared_bitmap_manager.cc
cc/test/test_web_graphics_context_3d.cc
cc/test/tiled_layer_test_common.cc
cc/trees/layer_tree_host.cc
cc/trees/layer_tree_host_common_unittest.cc
cc/trees/layer_tree_host_impl.cc
cc/trees/layer_tree_host_impl_unittest.cc
cc/trees/layer_tree_host_unittest.cc
cc/trees/layer_tree_host_unittest_animation.cc
cc/trees/layer_tree_host_unittest_context.cc
cc/trees/layer_tree_host_unittest_copyrequest.cc
cc/trees/layer_tree_host_unittest_no_message_loop.cc
cc/trees/layer_tree_host_unittest_scroll.cc
cc/trees/layer_tree_impl.cc
cc/trees/layer_tree_impl_unittest.cc
cc/trees/occlusion_tracker_perftest.cc
cc/trees/occlusion_tracker_unittest.cc
cc/trees/single_thread_proxy.cc
cc/trees/thread_proxy.cc
cc/trees/tree_synchronizer.cc
cc/trees/tree_synchronizer_unittest.cc