Standardize usage of virtual/override/final in chrome/browser/media_galleries
commit730bdd256a750c64663e30fcc0e998e4aa46e913
authordcheng <dcheng@chromium.org>
Wed, 22 Oct 2014 01:10:52 +0000 (21 18:10 -0700)
committerCommit bot <commit-bot@chromium.org>
Wed, 22 Oct 2014 04:03:23 +0000 (22 04:03 +0000)
tree653df888ebfa681ef52a750371d11d050459ca9e
parent6bf6f20cdedc5e85c87c5b6f6686706a72a63f0c
Standardize usage of virtual/override/final in chrome/browser/media_galleries

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=tommycli@chromium.org

Review URL: https://codereview.chromium.org/660343006

Cr-Commit-Position: refs/heads/master@{#300595}
44 files changed:
chrome/browser/media_galleries/fileapi/av_scanning_file_validator.h
chrome/browser/media_galleries/fileapi/device_media_async_file_util.h
chrome/browser/media_galleries/fileapi/iphoto_data_provider.h
chrome/browser/media_galleries/fileapi/iphoto_data_provider_browsertest.cc
chrome/browser/media_galleries/fileapi/iphoto_file_util.h
chrome/browser/media_galleries/fileapi/iphoto_file_util_unittest.cc
chrome/browser/media_galleries/fileapi/itunes_data_provider.h
chrome/browser/media_galleries/fileapi/itunes_data_provider_browsertest.cc
chrome/browser/media_galleries/fileapi/itunes_file_util.h
chrome/browser/media_galleries/fileapi/itunes_file_util_unittest.cc
chrome/browser/media_galleries/fileapi/media_file_system_backend.h
chrome/browser/media_galleries/fileapi/media_file_validator_factory.cc
chrome/browser/media_galleries/fileapi/media_file_validator_factory.h
chrome/browser/media_galleries/fileapi/mtp_file_stream_reader.h
chrome/browser/media_galleries/fileapi/native_media_file_util.h
chrome/browser/media_galleries/fileapi/picasa_data_provider_browsertest.cc
chrome/browser/media_galleries/fileapi/picasa_file_util.h
chrome/browser/media_galleries/fileapi/picasa_file_util_unittest.cc
chrome/browser/media_galleries/fileapi/readahead_file_stream_reader.h
chrome/browser/media_galleries/fileapi/safe_audio_video_checker.h
chrome/browser/media_galleries/fileapi/safe_iapps_library_parser.h
chrome/browser/media_galleries/fileapi/safe_media_metadata_parser.h
chrome/browser/media_galleries/fileapi/safe_picasa_album_table_reader.h
chrome/browser/media_galleries/fileapi/safe_picasa_albums_indexer.h
chrome/browser/media_galleries/fileapi/supported_audio_video_checker.h
chrome/browser/media_galleries/fileapi/supported_image_type_validator.cc
chrome/browser/media_galleries/fileapi/supported_image_type_validator.h
chrome/browser/media_galleries/gallery_watch_manager.h
chrome/browser/media_galleries/gallery_watch_manager_unittest.cc
chrome/browser/media_galleries/mac/mtp_device_delegate_impl_mac.h
chrome/browser/media_galleries/mac/mtp_device_delegate_impl_mac.mm
chrome/browser/media_galleries/media_file_system_registry.cc
chrome/browser/media_galleries/media_file_system_registry.h
chrome/browser/media_galleries/media_file_system_registry_unittest.cc
chrome/browser/media_galleries/media_galleries_dialog_controller_test_util.h
chrome/browser/media_galleries/media_galleries_permission_controller.h
chrome/browser/media_galleries/media_galleries_permissions_unittest.cc
chrome/browser/media_galleries/media_galleries_preferences.h
chrome/browser/media_galleries/media_galleries_preferences_factory.h
chrome/browser/media_galleries/media_galleries_preferences_unittest.cc
chrome/browser/media_galleries/media_galleries_scan_result_controller.h
chrome/browser/media_galleries/media_gallery_context_menu.h
chrome/browser/media_galleries/media_scan_manager.h
chrome/browser/media_galleries/media_scan_manager_unittest.cc