| commit | 70f5220a69a64377fb9d27a72941941d7ea7fa2c | |
| author | azarchs <azarchs@chromium.org> | |
| Mon, 23 Feb 2015 16:43:11 +0000 (23 08:43 -0800) | ||
| committer | Commit bot <commit-bot@chromium.org> | |
| Mon, 23 Feb 2015 16:44:05 +0000 (23 16:44 +0000) | ||
| tree | b93915d3aaa446a75a6d6a1cd9ab61c7eec99f61 | treesnapshot (tar.gz zip) |
| parent | 5d9334634f406946ceb7b426ab439221dfb978f8 | commitdiff |
Improve symbol_extractor.CreateNameToSymbolInfo handling of duplicate symbols.
If a symbol appears more than once in the binary, return the lowest offset for
that symbol, rather than the last one. Also warn about duplicated symbols.
There are a couple hundred in libchrome.so. Further investigation is needed to
determine why this is even possible, but in the mean time this should fix the
orderfile bot redness.
Review URL: https://codereview.chromium.org/947073003
Cr-Commit-Position: refs/heads/master@{#317592}
If a symbol appears more than once in the binary, return the lowest offset for
that symbol, rather than the last one. Also warn about duplicated symbols.
There are a couple hundred in libchrome.so. Further investigation is needed to
determine why this is even possible, but in the mean time this should fix the
orderfile bot redness.
Review URL: https://codereview.chromium.org/947073003
Cr-Commit-Position: refs/heads/master@{#317592}
| tools/cygprofile/symbol_extractor.py | diffblobblamehistory | |
| tools/cygprofile/symbol_extractor_unittest.py | diffblobblamehistory |