| commit | 6d34c3450bc604a9a3f752839442b9d5f87a2a4b | |
| author | blundell <blundell@chromium.org> | |
| Fri, 11 Sep 2015 09:09:10 +0000 (11 02:09 -0700) | ||
| committer | Commit bot <commit-bot@chromium.org> | |
| Fri, 11 Sep 2015 09:09:59 +0000 (11 09:09 +0000) | ||
| tree | 570fb44fb0a18c078e060f6cd1a9b05d402f32e3 | treesnapshot (tar.gz zip) |
| parent | d630a84f6778b33e2a63d8f26079f2b8d419712a | commitdiff |
Eliminate BaseSessionServiceDelegateImpl
PersistentTabRestoreService::Delegate is slated for componentization. However,
it inherits from BaseSessionServiceDelegateImpl, which contains //chrome-level
functionality.
This CL eliminates BaseSessionServiceDelegateImpl, instead having
PersistentTabRestoreService::Delegate and SessionService each inherit directly
from BaseSessionServiceDelegate. The one non-trivial method in
BaseSessionServiceDelegateImpl (ShouldTrackEntry()) is pulled out into a
standalone //chrome-level util function to avoid code duplication between
ChromeTabRestoreServiceClient and SessionService.
BUG=530165
Review URL: https://codereview.chromium.org/1331173002
Cr-Commit-Position: refs/heads/master@{#348363}
PersistentTabRestoreService::Delegate is slated for componentization. However,
it inherits from BaseSessionServiceDelegateImpl, which contains //chrome-level
functionality.
This CL eliminates BaseSessionServiceDelegateImpl, instead having
PersistentTabRestoreService::Delegate and SessionService each inherit directly
from BaseSessionServiceDelegate. The one non-trivial method in
BaseSessionServiceDelegateImpl (ShouldTrackEntry()) is pulled out into a
standalone //chrome-level util function to avoid code duplication between
ChromeTabRestoreServiceClient and SessionService.
BUG=530165
Review URL: https://codereview.chromium.org/1331173002
Cr-Commit-Position: refs/heads/master@{#348363}
12 files changed: