| commit | 6cf04694c355457102bb93c47b63754ea43d5f60 | |
| author | gab <gab@chromium.org> | |
| Wed, 10 Dec 2014 03:52:55 +0000 (9 19:52 -0800) | ||
| committer | Commit bot <commit-bot@chromium.org> | |
| Wed, 10 Dec 2014 03:55:00 +0000 (10 03:55 +0000) | ||
| tree | 1f0d1136d04f8a08b5a796282a1cef222c9e6d24 | treesnapshot (tar.gz zip) |
| parent | 27018cea56f6f1b3521975657acedbd20206c31a | commitdiff |
Only show a warning for frames pointing at UwS URLs, not resources.
Where "frames" applies to the top-level frame, <iframe>'s, and <frame>'s.
Augmented SafeBrowsingBlockingPageBrowserTest to run for all 3 of MALWARE/PHISHING/UNWANTED threats.
BUG=439043
TEST=
A) New SafeBrowsingServiceTest.UnwantedImgIgnored test doesn't pass without corresponding ui_manager.cc change.
B) All SafeBrowsingBlockingPageBrowserTest augmented to run for UNWANTED_URL and PHISHING threats as well pass.
C) Manually verified that an iframe/frame/main_frame pointing to an Unwanted site triggers an interstitial, yet an image inclusion doesn't.
Review URL: https://codereview.chromium.org/770503004
Cr-Commit-Position: refs/heads/master@{#307636}
Where "frames" applies to the top-level frame, <iframe>'s, and <frame>'s.
Augmented SafeBrowsingBlockingPageBrowserTest to run for all 3 of MALWARE/PHISHING/UNWANTED threats.
BUG=439043
TEST=
A) New SafeBrowsingServiceTest.UnwantedImgIgnored test doesn't pass without corresponding ui_manager.cc change.
B) All SafeBrowsingBlockingPageBrowserTest augmented to run for UNWANTED_URL and PHISHING threats as well pass.
C) Manually verified that an iframe/frame/main_frame pointing to an Unwanted site triggers an interstitial, yet an image inclusion doesn't.
Review URL: https://codereview.chromium.org/770503004
Cr-Commit-Position: refs/heads/master@{#307636}