| commit | 6ce1dd735b7c1ea85c23a8df814af2444caaeab2 | |
| author | kinaba@chromium.org <kinaba@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Wed, 16 Jul 2014 22:19:05 +0000 (16 22:19 +0000) | ||
| committer | kinaba@chromium.org <kinaba@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Wed, 16 Jul 2014 22:19:05 +0000 (16 22:19 +0000) | ||
| tree | 6f2d66559b7d517bfe4f1f5a8ff9d6481fc2a3fc | treesnapshot (tar.gz zip) |
| parent | 393561d2f36decadb224990c7860eb5272ec6dcb | commitdiff |
Files.app: mpeg metadata parser must not be stateful.
The previous code writes the parsed metadata to |metadata| dictionary
remembered in |this.rootParser_|, but this is wrong.
The parser class is shared among multiple parses, so to correctly
distinguish concurrent parsing activity, it cannot store states
in the member fields.
BUG=172989
Review URL: https://codereview.chromium.org/391313003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283545 0039d316-1c4b-4281-b951-d872f2087c98
The previous code writes the parsed metadata to |metadata| dictionary
remembered in |this.rootParser_|, but this is wrong.
The parser class is shared among multiple parses, so to correctly
distinguish concurrent parsing activity, it cannot store states
in the member fields.
BUG=172989
Review URL: https://codereview.chromium.org/391313003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283545 0039d316-1c4b-4281-b951-d872f2087c98
| ui/file_manager/file_manager/foreground/js/metadata/mpeg_parser.js | diffblobblamehistory |