| commit | 6cade219e58c8806bdbd02316d78f49c8fa97996 | |
| author | finnur@google.com <finnur@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Wed, 3 Dec 2008 00:32:22 +0000 (3 00:32 +0000) | ||
| committer | finnur@google.com <finnur@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Wed, 3 Dec 2008 00:32:22 +0000 (3 00:32 +0000) | ||
| tree | cd506501644bdb420f1dec4f705f79b0857f0795 | treesnapshot (tar.gz zip) |
| parent | cd7ef4f027ae36e80e368f967d1b98e1a3e3bde8 | commitdiff |
Fix issue 4829: No file extensions listed when saving images
We were not supplying a filter list for the Save As dialog.
Now that we do, the user can select between, for example, say *.jpg and *.* as filters and we behave as follows:
With a *.jpg filter active, user enters foo and we save the file as: foo.jpg
With a *.jpg filter active, user enters foo. and we save the file as: foo..jpg (which is consistent with IE)
With a *.jpg filter active, user enters foo.jpg, we save the file as: foo.jpg
With a *.jpg filter active, user enters foo.jpeg, we save the file as: foo.jpeg (not foo.jpg or foo.jpeg.jpg)
With a *.* filter active, we respect whatever user enters as extension, except if the filename contains one or more trailing dots then we strip out all those trailing dots.
Also test filenames created when saving web pages, as opposed to images (should work as before).
Review URL: http://codereview.chromium.org/12836
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6258 0039d316-1c4b-4281-b951-d872f2087c98
We were not supplying a filter list for the Save As dialog.
Now that we do, the user can select between, for example, say *.jpg and *.* as filters and we behave as follows:
With a *.jpg filter active, user enters foo and we save the file as: foo.jpg
With a *.jpg filter active, user enters foo. and we save the file as: foo..jpg (which is consistent with IE)
With a *.jpg filter active, user enters foo.jpg, we save the file as: foo.jpg
With a *.jpg filter active, user enters foo.jpeg, we save the file as: foo.jpeg (not foo.jpg or foo.jpeg.jpg)
With a *.* filter active, we respect whatever user enters as extension, except if the filename contains one or more trailing dots then we strip out all those trailing dots.
Also test filenames created when saving web pages, as opposed to images (should work as before).
Review URL: http://codereview.chromium.org/12836
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6258 0039d316-1c4b-4281-b951-d872f2087c98