| commit | 6ba7de5c5c4f8cd500993fcd73f41c977a6050b3 | |
| author | pkasting@chromium.org <pkasting@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Thu, 19 Dec 2013 23:47:32 +0000 (19 23:47 +0000) | ||
| committer | pkasting@chromium.org <pkasting@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Thu, 19 Dec 2013 23:47:32 +0000 (19 23:47 +0000) | ||
| tree | ef38e671a8a919a8515e6c406736331894aecbf7 | treesnapshot (tar.gz zip) |
| parent | a62d83bc7053c199dc5b2d61d0da84da8d6f1ddf | commitdiff |
Clean up StatusBubbleViews::StatusView some:
* We dont really use anything in Label, so don't inherit from it, just inherit
from View.
* Be consistent about referring to "states" rather than sometimes calling them
"stages".
* Enums go before constructors.
* Don't inline complex functions in non-test code.
* Cheap accessors should be named unix_hacker()-style.
* Consistently use FontList in place of Font everywhere.
BUG=none
TEST=none
R=sky@chromium.org
Review URL: https://codereview.chromium.org/108573005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241982 0039d316-1c4b-4281-b951-d872f2087c98
* We dont really use anything in Label, so don't inherit from it, just inherit
from View.
* Be consistent about referring to "states" rather than sometimes calling them
"stages".
* Enums go before constructors.
* Don't inline complex functions in non-test code.
* Cheap accessors should be named unix_hacker()-style.
* Consistently use FontList in place of Font everywhere.
BUG=none
TEST=none
R=sky@chromium.org
Review URL: https://codereview.chromium.org/108573005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241982 0039d316-1c4b-4281-b951-d872f2087c98
| chrome/browser/ui/views/status_bubble_views.cc | diffblobblamehistory |