| commit | 69568e550fa0ce568787464aaea6c8a2fe150cd8 | |
| author | oshima@chromium.org <oshima@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Thu, 20 Jun 2013 23:05:22 +0000 (20 23:05 +0000) | ||
| committer | oshima@chromium.org <oshima@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Thu, 20 Jun 2013 23:05:22 +0000 (20 23:05 +0000) | ||
| tree | 9529315c5a170104ecf1e52d443f8a49d19bcced | treesnapshot (tar.gz zip) |
| parent | 616df578e3ea9a1cb3369831553bb21cabf1f2d6 | commitdiff |
Revert 207508 "Add a hide_layer_and_subtree() flag to cc::Layer"
> Add a hide_layer_and_subtree() flag to cc::Layer
>
> This flag does what it says. We can use this flag to simplify ui::Layer
> as it was recursively calling SetIsDrawable() instead, and now can just
> SetHideLayerAndSubtree() on a single layer.
>
> This flag is needed to allow readbacks of layers that are have hidden
> visibility (possibly due to an ancestor).
>
> Tests:
> LayerTest.CheckPropertyChangeCausesCorrectBehavior
> LayerImplTest.VerifyLayerChangesAreTrackedProperly
> LayerTreeHostCommonTest.SubtreeHidden_SingleLayer
> LayerTreeHostCommonTest.SubtreeHidden_SingleLayerImpl
> LayerTreeHostCommonTest.SubtreeHidden_TwoLayers
> LayerTreeHostCommonTest.SubtreeHidden_TwoLayersImpl
>
> R=enne, piman
> BUG=242572
>
> Review URL: https://chromiumcodereview.appspot.com/16896017
reveting this because this broke login screen on cros. (crbug.com/252494)
TBR=danakj@chromium.org
Review URL: https://codereview.chromium.org/17279011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207627 0039d316-1c4b-4281-b951-d872f2087c98
> Add a hide_layer_and_subtree() flag to cc::Layer
>
> This flag does what it says. We can use this flag to simplify ui::Layer
> as it was recursively calling SetIsDrawable() instead, and now can just
> SetHideLayerAndSubtree() on a single layer.
>
> This flag is needed to allow readbacks of layers that are have hidden
> visibility (possibly due to an ancestor).
>
> Tests:
> LayerTest.CheckPropertyChangeCausesCorrectBehavior
> LayerImplTest.VerifyLayerChangesAreTrackedProperly
> LayerTreeHostCommonTest.SubtreeHidden_SingleLayer
> LayerTreeHostCommonTest.SubtreeHidden_SingleLayerImpl
> LayerTreeHostCommonTest.SubtreeHidden_TwoLayers
> LayerTreeHostCommonTest.SubtreeHidden_TwoLayersImpl
>
> R=enne, piman
> BUG=242572
>
> Review URL: https://chromiumcodereview.appspot.com/16896017
reveting this because this broke login screen on cros. (crbug.com/252494)
TBR=danakj@chromium.org
Review URL: https://codereview.chromium.org/17279011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207627 0039d316-1c4b-4281-b951-d872f2087c98
12 files changed: