| commit | 6903d72496f5f9d82c2664dfe64ee5fcb88539e6 | |
| author | rouslan@chromium.org <rouslan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Fri, 13 Jun 2014 07:00:05 +0000 (13 07:00 +0000) | ||
| committer | rouslan@chromium.org <rouslan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Fri, 13 Jun 2014 07:00:05 +0000 (13 07:00 +0000) | ||
| tree | 10c0253766290eca6bf3d47693186cb86367b04c | treesnapshot (tar.gz zip) |
| parent | 9dc9d50342bd25ca4e997daf6d056b52dde54234 | commitdiff |
Revert of Blink roll 176039:176057 (https://codereview.chromium.org/331753003/)
Reason for revert:
Appears to have broken FormStructureBrowserTest.DataDrivenHeuristics* on:
http://build.chromium.org/p/chromium.mac/buildstatus?builder=Mac%2010.6%20Tests%20%28dbg%29%281%29&number=50265
http://build.chromium.org/p/chromium.mac/buildstatus?builder=Mac%2010.6%20Tests%20%28dbg%29%282%29&number=52508
http://build.chromium.org/p/chromium.mac/buildstatus?builder=Mac%2010.6%20Tests%20%28dbg%29%283%29&number=50543
http://build.chromium.org/p/chromium.mac/buildstatus?builder=Mac%2010.6%20Tests%20%28dbg%29%284%29&number=41994
... etc
Example failure:
FormStructureBrowserTest.DataDrivenHeuristics02 (run #1):
[ RUN ] FormStructureBrowserTest.DataDrivenHeuristics02
ASSERTION FAILED: !m_normalFlowListDirty
../../third_party/WebKit/Source/core/rendering/RenderLayerStackingNode.h(117) : Vector\u003CWebCore::RenderLayerStackingNode *> *WebCore::RenderLayerStackingNode::normalFlowList() const
1 0x150a66aa WebCore::RenderLayerStackingNode::normalFlowList() const
2 0x14fc13fd WebCore::RenderLayerStackingNodeIterator::next()
3 0x15112c46 WebCore::RenderLayerCompositor::recursiveRepaintLayer(WebCore::RenderLayer*)
4 0x15112b5d WebCore::RenderLayerCompositor::repaintCompositedLayers()
5 0x150ad91e WebCore::RenderView::repaintViewAndCompositedLayers()
6 0x13d49b5b WebCore::Document::styleResolverChanged(WebCore::StyleResolverUpdateMode)
7 0x13d499fa WebCore::Document::updateLayoutIgnorePendingStylesheets(WebCore::Document::RunPostLayoutTasks)
8 0x121afa0f blink::WebNode::isFocusable() const
9 0x4879ae0 autofill::WebFormControlElementToFormField(blink::WebFormControlElement const&, autofill::ExtractMask, autofill::FormFieldData*)
10 0x487ad24 autofill::WebFormElementToFormData(blink::WebFormElement const&, blink::WebFormControlElement const&, autofill::RequirementsMask, autofill::ExtractMask, autofill::FormData*, autofill::FormFieldData*)
11 0x4886b26 autofill::FormCache::ExtractNewForms(blink::WebFrame const&, std::vector\u003Cautofill::FormData, std::allocator\u003Cautofill::FormData> >*)
12 0x486fe06 autofill::AutofillAgent::ProcessForms(blink::WebLocalFrame const&)
13 0x486fd5f autofill::AutofillAgent::DidFinishDocumentLoad(blink::WebLocalFrame*)
14 0x1bbac68f content::RenderFrameImpl::didFinishDocumentLoad(blink::WebLocalFrame*)
15 0x1bbac83f non-virtual thunk to content::RenderFrameImpl::didFinishDocumentLoad(blink::WebLocalFrame*)
16 0x120820a2 blink::FrameLoaderClientImpl::dispatchDidFinishDocumentLoad()
17 0x14bc1255 WebCore::FrameLoader::finishedParsing()
18 0x13d5a9a9 WebCore::Document::finishedParsing()
19 0x142fa9a3 WebCore::HTMLConstructionSite::finishedParsing()
20 0x14374a61 WebCore::HTMLTreeBuilder::finished()
21 0x1430c054 WebCore::HTMLDocumentParser::end()
22 0x14306017 WebCore::HTMLDocumentParser::attemptToRunDeferredScriptsAndEnd()
23 0x14305c6b WebCore::HTMLDocumentParser::prepareToStopParsing()
24 0x14309e6a WebCore::HTMLDocumentParser::processParsedChunkFromBackgroundParser(WTF::PassOwnPtr\u003CWebCore::HTMLDocumentParser::ParsedChunk>)
25 0x14307c22 WebCore::HTMLDocumentParser::pumpPendingSpeculations()
26 0x14308775 WebCore::HTMLDocumentParser::didReceiveParsedChunkFromBackgroundParser(WTF::PassOwnPtr\u003CWebCore::HTMLDocumentParser::ParsedChunk>)
27 0x142f01a7 WTF::FunctionWrapper\u003Cvoid (WebCore::HTMLDocumentParser::*)(WTF::PassOwnPtr\u003CWebCore::HTMLDocumentParser::ParsedChunk>)>::operator()(WTF::WeakPtr\u003CWebCore::HTMLDocumentParser> const&, WTF::PassOwnPtr\u003CWebCore::HTMLDocumentParser::ParsedChunk>)
28 0x142f00ae WTF::BoundFunctionImpl\u003CWTF::FunctionWrapper\u003Cvoid (WebCore::HTMLDocumentParser::*)(WTF::PassOwnPtr\u003CWebCore::HTMLDocumentParser::ParsedChunk>)>, void ()(WTF::WeakPtr\u003CWebCore::HTMLDocumentParser>, WTF::PassOwnPtr\u003CWebCore::HTMLDocumentParser::ParsedChunk>)>::operator()()
29 0x252115b3 WTF::Function\u003Cvoid ()()>::operator()() const
30 0x252110c1 _ZN3WTFL18callFunctionObjectEPv
31 0x1b3d6910 base::internal::RunnableAdapter\u003Cvoid (*)(void*)>::Run(void* const&)
../../components/autofill/core/browser/data_driven_test.cc:62: Failure
Value of: output
Actual: ""
Expected: output_file_contents
Which is: "NAME_FULL | BillName | Name on Account* | \nADDRESS_HOME_COUNTRY | BillCountry | Country* | UNITED STATES\nADDRESS_HOME_LINE1 | BillStreet1 | Address * | \nADDRESS_HOME_LINE2 | BillStreet2 | Address * | \nUNKNOWN_TYPE | ddlRedoClassification | Address * | \nADDRESS_HOME_CITY | BillCity | Town/City* | \nADDRESS_HOME_STATE | BillState | State/Province* | \nUNKNOWN_TYPE | BillStateOther | State/Province* | \nADDRESS_HOME_ZIP | BillZip | Zip/Postal Code* | \nPHONE_HOME_WHOLE_NUMBER | BillPhone | Phone Number* | \nEMAIL_ADDRESS | BillEmail | Email Address* | \nUNKNOWN_TYPE | cbStoreSpecial | | on\nUNKNOWN_TYPE | ShipDestination | | billaddress\nUNKNOWN_TYPE | ShipDestination | Ship to my billing address | shipaddress\nNAME_FULL | ShipName | Recipient Name* | \nADDRESS_HOME_COUNTRY | ShipCountry | Country* | UNITED STATES\nADDRESS_HOME_LINE1 | ShipStreet1 | Address* | \nADDRESS_HOME_LINE2 | ShipStreet2 | Address* | \nADDRESS_HOME_CITY | ShipCity | Town/City* | \nADDRESS_HOME_STATE | ShipState | State/Province* | \nUNKNOWN_TYPE | ShipStateOther | State/Province* | \nADDRESS_HOME_ZIP | ShipZip | Zip/Postal Code* | \nUNKNOWN_TYPE | ShowGiftMsg | 2 Shipping Address | on\nADDRESS_HOME_STREET_ADDRESS | GiftMessage | 2 Shipping Address | \nUNKNOWN_TYPE | countdown | You have | 300\nUNKNOWN_TYPE | ApplyGiftWrap | 2 Shipping Address | on\nUNKNOWN_TYPE | txtCoupon | Apply Promo Code | \nUNKNOWN_TYPE | PaymentMethod | | PayByCafeCash\nUNKNOWN_TYPE | PaymentMethod | | PayByGC\nUNKNOWN_TYPE | PaymentMethod | | PayByCCGC\nUNKNOWN_TYPE | PaymentMethod | | PayByCC\nCREDIT_CARD_NUMBER | txtCCAccount | Credit Card No.* | \nCREDIT_CARD_EXP_MONTH | ccExp$MonthDrop | Expiration Date* | 06 (June)\nCREDIT_CARD_EXP_4_DIGIT_YEAR | ccExp$YearDrop | Expiration Date* | 2011\nUNKNOWN_TYPE | PaymentMethod | Expiration Date* | PayByCheck\nUNKNOWN_TYPE | PaymentMethod | | PayByPayPal\n"
Google Test trace:
../../components/autofill/core/browser/data_driven_test.cc:48: 02_checkout_cafepress.com.html
[ FAILED ] FormStructureBrowserTest.DataDrivenHeuristics02, where TypeParam = and GetParam() = (3133 ms)
Original issue's description:
> Blink roll 176039:176057
>
> http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=176040:176057&mode=html
> TBR=yhirano@chromium.org,dpranke@chromium.org
> BUG=
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276929
TBR=dpranke@chromium.org,yhirano@chromium.org,dpranke@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=
Review URL: https://codereview.chromium.org/330203004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276951 0039d316-1c4b-4281-b951-d872f2087c98
Reason for revert:
Appears to have broken FormStructureBrowserTest.DataDrivenHeuristics* on:
http://build.chromium.org/p/chromium.mac/buildstatus?builder=Mac%2010.6%20Tests%20%28dbg%29%281%29&number=50265
http://build.chromium.org/p/chromium.mac/buildstatus?builder=Mac%2010.6%20Tests%20%28dbg%29%282%29&number=52508
http://build.chromium.org/p/chromium.mac/buildstatus?builder=Mac%2010.6%20Tests%20%28dbg%29%283%29&number=50543
http://build.chromium.org/p/chromium.mac/buildstatus?builder=Mac%2010.6%20Tests%20%28dbg%29%284%29&number=41994
... etc
Example failure:
FormStructureBrowserTest.DataDrivenHeuristics02 (run #1):
[ RUN ] FormStructureBrowserTest.DataDrivenHeuristics02
ASSERTION FAILED: !m_normalFlowListDirty
../../third_party/WebKit/Source/core/rendering/RenderLayerStackingNode.h(117) : Vector\u003CWebCore::RenderLayerStackingNode *> *WebCore::RenderLayerStackingNode::normalFlowList() const
1 0x150a66aa WebCore::RenderLayerStackingNode::normalFlowList() const
2 0x14fc13fd WebCore::RenderLayerStackingNodeIterator::next()
3 0x15112c46 WebCore::RenderLayerCompositor::recursiveRepaintLayer(WebCore::RenderLayer*)
4 0x15112b5d WebCore::RenderLayerCompositor::repaintCompositedLayers()
5 0x150ad91e WebCore::RenderView::repaintViewAndCompositedLayers()
6 0x13d49b5b WebCore::Document::styleResolverChanged(WebCore::StyleResolverUpdateMode)
7 0x13d499fa WebCore::Document::updateLayoutIgnorePendingStylesheets(WebCore::Document::RunPostLayoutTasks)
8 0x121afa0f blink::WebNode::isFocusable() const
9 0x4879ae0 autofill::WebFormControlElementToFormField(blink::WebFormControlElement const&, autofill::ExtractMask, autofill::FormFieldData*)
10 0x487ad24 autofill::WebFormElementToFormData(blink::WebFormElement const&, blink::WebFormControlElement const&, autofill::RequirementsMask, autofill::ExtractMask, autofill::FormData*, autofill::FormFieldData*)
11 0x4886b26 autofill::FormCache::ExtractNewForms(blink::WebFrame const&, std::vector\u003Cautofill::FormData, std::allocator\u003Cautofill::FormData> >*)
12 0x486fe06 autofill::AutofillAgent::ProcessForms(blink::WebLocalFrame const&)
13 0x486fd5f autofill::AutofillAgent::DidFinishDocumentLoad(blink::WebLocalFrame*)
14 0x1bbac68f content::RenderFrameImpl::didFinishDocumentLoad(blink::WebLocalFrame*)
15 0x1bbac83f non-virtual thunk to content::RenderFrameImpl::didFinishDocumentLoad(blink::WebLocalFrame*)
16 0x120820a2 blink::FrameLoaderClientImpl::dispatchDidFinishDocumentLoad()
17 0x14bc1255 WebCore::FrameLoader::finishedParsing()
18 0x13d5a9a9 WebCore::Document::finishedParsing()
19 0x142fa9a3 WebCore::HTMLConstructionSite::finishedParsing()
20 0x14374a61 WebCore::HTMLTreeBuilder::finished()
21 0x1430c054 WebCore::HTMLDocumentParser::end()
22 0x14306017 WebCore::HTMLDocumentParser::attemptToRunDeferredScriptsAndEnd()
23 0x14305c6b WebCore::HTMLDocumentParser::prepareToStopParsing()
24 0x14309e6a WebCore::HTMLDocumentParser::processParsedChunkFromBackgroundParser(WTF::PassOwnPtr\u003CWebCore::HTMLDocumentParser::ParsedChunk>)
25 0x14307c22 WebCore::HTMLDocumentParser::pumpPendingSpeculations()
26 0x14308775 WebCore::HTMLDocumentParser::didReceiveParsedChunkFromBackgroundParser(WTF::PassOwnPtr\u003CWebCore::HTMLDocumentParser::ParsedChunk>)
27 0x142f01a7 WTF::FunctionWrapper\u003Cvoid (WebCore::HTMLDocumentParser::*)(WTF::PassOwnPtr\u003CWebCore::HTMLDocumentParser::ParsedChunk>)>::operator()(WTF::WeakPtr\u003CWebCore::HTMLDocumentParser> const&, WTF::PassOwnPtr\u003CWebCore::HTMLDocumentParser::ParsedChunk>)
28 0x142f00ae WTF::BoundFunctionImpl\u003CWTF::FunctionWrapper\u003Cvoid (WebCore::HTMLDocumentParser::*)(WTF::PassOwnPtr\u003CWebCore::HTMLDocumentParser::ParsedChunk>)>, void ()(WTF::WeakPtr\u003CWebCore::HTMLDocumentParser>, WTF::PassOwnPtr\u003CWebCore::HTMLDocumentParser::ParsedChunk>)>::operator()()
29 0x252115b3 WTF::Function\u003Cvoid ()()>::operator()() const
30 0x252110c1 _ZN3WTFL18callFunctionObjectEPv
31 0x1b3d6910 base::internal::RunnableAdapter\u003Cvoid (*)(void*)>::Run(void* const&)
../../components/autofill/core/browser/data_driven_test.cc:62: Failure
Value of: output
Actual: ""
Expected: output_file_contents
Which is: "NAME_FULL | BillName | Name on Account* | \nADDRESS_HOME_COUNTRY | BillCountry | Country* | UNITED STATES\nADDRESS_HOME_LINE1 | BillStreet1 | Address * | \nADDRESS_HOME_LINE2 | BillStreet2 | Address * | \nUNKNOWN_TYPE | ddlRedoClassification | Address * | \nADDRESS_HOME_CITY | BillCity | Town/City* | \nADDRESS_HOME_STATE | BillState | State/Province* | \nUNKNOWN_TYPE | BillStateOther | State/Province* | \nADDRESS_HOME_ZIP | BillZip | Zip/Postal Code* | \nPHONE_HOME_WHOLE_NUMBER | BillPhone | Phone Number* | \nEMAIL_ADDRESS | BillEmail | Email Address* | \nUNKNOWN_TYPE | cbStoreSpecial | | on\nUNKNOWN_TYPE | ShipDestination | | billaddress\nUNKNOWN_TYPE | ShipDestination | Ship to my billing address | shipaddress\nNAME_FULL | ShipName | Recipient Name* | \nADDRESS_HOME_COUNTRY | ShipCountry | Country* | UNITED STATES\nADDRESS_HOME_LINE1 | ShipStreet1 | Address* | \nADDRESS_HOME_LINE2 | ShipStreet2 | Address* | \nADDRESS_HOME_CITY | ShipCity | Town/City* | \nADDRESS_HOME_STATE | ShipState | State/Province* | \nUNKNOWN_TYPE | ShipStateOther | State/Province* | \nADDRESS_HOME_ZIP | ShipZip | Zip/Postal Code* | \nUNKNOWN_TYPE | ShowGiftMsg | 2 Shipping Address | on\nADDRESS_HOME_STREET_ADDRESS | GiftMessage | 2 Shipping Address | \nUNKNOWN_TYPE | countdown | You have | 300\nUNKNOWN_TYPE | ApplyGiftWrap | 2 Shipping Address | on\nUNKNOWN_TYPE | txtCoupon | Apply Promo Code | \nUNKNOWN_TYPE | PaymentMethod | | PayByCafeCash\nUNKNOWN_TYPE | PaymentMethod | | PayByGC\nUNKNOWN_TYPE | PaymentMethod | | PayByCCGC\nUNKNOWN_TYPE | PaymentMethod | | PayByCC\nCREDIT_CARD_NUMBER | txtCCAccount | Credit Card No.* | \nCREDIT_CARD_EXP_MONTH | ccExp$MonthDrop | Expiration Date* | 06 (June)\nCREDIT_CARD_EXP_4_DIGIT_YEAR | ccExp$YearDrop | Expiration Date* | 2011\nUNKNOWN_TYPE | PaymentMethod | Expiration Date* | PayByCheck\nUNKNOWN_TYPE | PaymentMethod | | PayByPayPal\n"
Google Test trace:
../../components/autofill/core/browser/data_driven_test.cc:48: 02_checkout_cafepress.com.html
[ FAILED ] FormStructureBrowserTest.DataDrivenHeuristics02, where TypeParam = and GetParam() = (3133 ms)
Original issue's description:
> Blink roll 176039:176057
>
> http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=176040:176057&mode=html
> TBR=yhirano@chromium.org,dpranke@chromium.org
> BUG=
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276929
TBR=dpranke@chromium.org,yhirano@chromium.org,dpranke@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=
Review URL: https://codereview.chromium.org/330203004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276951 0039d316-1c4b-4281-b951-d872f2087c98
| DEPS | diffblobblamehistory |