| commit | 68a3c8e55305c72c9e8450dd94d786fe04473173 | |
| author | jvoung@google.com <jvoung@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Mon, 9 Dec 2013 22:26:59 +0000 (9 22:26 +0000) | ||
| committer | jvoung@google.com <jvoung@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Mon, 9 Dec 2013 22:26:59 +0000 (9 22:26 +0000) | ||
| tree | a343dea2a4233ef1e0d1b18502e4c5a84e05c2f0 | treesnapshot (tar.gz zip) |
| parent | 7f2b1a0e30aa1cadba1266ef922bcb7ddb081494 | commitdiff |
Revert/Fix "Disable PnaclHeaderTest.TestHasPnaclHeader."
This reverts r236737.
The test was failing consistently because of a DCHECK added
in 236651, which was then reverted in 236693, but re-applied
at 236805 after this test was disabled. The issue is that
this test uses EmbeddedTestServer in a way that violated the
DCHECK (http://crbug.com/321422). We have to wait till after
SetUp to start the server now (perhaps the example usage
comments in embedded_test_server.h should no longer recommend
calling InitializeAndWaitUntilReady() in SetUp?).
Also, the dtor automatically does ShutdownAndWaitUntilComplete,
so no longer need to put that under TearDown().
BUG=315328
R=ncbray@chromium.org, oshima@chromium.org
Review URL: https://codereview.chromium.org/83073010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239575 0039d316-1c4b-4281-b951-d872f2087c98
This reverts r236737.
The test was failing consistently because of a DCHECK added
in 236651, which was then reverted in 236693, but re-applied
at 236805 after this test was disabled. The issue is that
this test uses EmbeddedTestServer in a way that violated the
DCHECK (http://crbug.com/321422). We have to wait till after
SetUp to start the server now (perhaps the example usage
comments in embedded_test_server.h should no longer recommend
calling InitializeAndWaitUntilReady() in SetUp?).
Also, the dtor automatically does ShutdownAndWaitUntilComplete,
so no longer need to put that under TearDown().
BUG=315328
R=ncbray@chromium.org, oshima@chromium.org
Review URL: https://codereview.chromium.org/83073010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239575 0039d316-1c4b-4281-b951-d872f2087c98
| chrome/test/nacl/pnacl_header_test.cc | diffblobblamehistory | |
| chrome/test/nacl/pnacl_header_test.h | diffblobblamehistory |