| commit | 689dfa60ce033bbba001df3aed52fc5e747f0e1f | |
| author | wittman@chromium.org <wittman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Sat, 2 Mar 2013 17:58:36 +0000 (2 17:58 +0000) | ||
| committer | wittman@chromium.org <wittman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Sat, 2 Mar 2013 17:58:36 +0000 (2 17:58 +0000) | ||
| tree | 6efa3197e897aa330c82bbb1bd9e95a1629c4b21 | treesnapshot (tar.gz zip) |
| parent | cf763cc12532ecdd89959d99ccf3a1eaf1e2d0d8 | commitdiff |
Remove the ConstrainedWindowViews class
Move the responsibility for creating the constrained-style window frame to the widget delegates, removing the last reason for the ConstrainedWindowViews class.
Move the web contents modal dialog factory function outside ConstrainedWindowViews and refactor to more closely match the Widget::CreateWindowWithParent interface. We can't use Widget::CreateWindowWithParent directly yet because we appear to be depending on setting params.child = true for proper window positioning, at least on Windows, and constructing with a gfx::NativeWindow parent results in strange test failures. Once the WCMD positioning interface is in place we should be able to investigate how to eliminate this function.
Remove the ConstrainedWindowViews class.
BUG=157161
Review URL: https://chromiumcodereview.appspot.com/12382038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@185731 0039d316-1c4b-4281-b951-d872f2087c98
Move the responsibility for creating the constrained-style window frame to the widget delegates, removing the last reason for the ConstrainedWindowViews class.
Move the web contents modal dialog factory function outside ConstrainedWindowViews and refactor to more closely match the Widget::CreateWindowWithParent interface. We can't use Widget::CreateWindowWithParent directly yet because we appear to be depending on setting params.child = true for proper window positioning, at least on Windows, and constructing with a gfx::NativeWindow parent results in strange test failures. Once the WCMD positioning interface is in place we should be able to investigate how to eliminate this function.
Remove the ConstrainedWindowViews class.
BUG=157161
Review URL: https://chromiumcodereview.appspot.com/12382038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@185731 0039d316-1c4b-4281-b951-d872f2087c98
15 files changed: