| commit | 684de3c1d61cf100dd218ad34a49773221f3e5a7 | |
| author | benjhayden@chromium.org <benjhayden@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Fri, 2 May 2014 18:29:09 +0000 (2 18:29 +0000) | ||
| committer | benjhayden@chromium.org <benjhayden@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Fri, 2 May 2014 18:29:09 +0000 (2 18:29 +0000) | ||
| tree | e49521e4fccfd54fbd145c5c77d1c6170ce083d9 | treesnapshot (tar.gz zip) |
| parent | f1ab3122f9bc1f8488b94dc71eee3101a26a5f38 | commitdiff |
Revert 267855 "Before this patch set, callback helper can bind p..."
> Before this patch set, callback helper can bind parameters to
> a null function, and the returned function seems to be a callable function.
> If a null function is called, it can crash.
>
>
> This patch makes the callback helper to return a null function
> for a null function bindings.
>
>
> BUG=None
> TEST=./unit_test --gtest_filter="DriveBackendCallbackHelperTest.*"
>
> Review URL: https://codereview.chromium.org/266823002
TBR=peria@chromium.org
Review URL: https://codereview.chromium.org/265093003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267879 0039d316-1c4b-4281-b951-d872f2087c98
> Before this patch set, callback helper can bind parameters to
> a null function, and the returned function seems to be a callable function.
> If a null function is called, it can crash.
>
>
> This patch makes the callback helper to return a null function
> for a null function bindings.
>
>
> BUG=None
> TEST=./unit_test --gtest_filter="DriveBackendCallbackHelperTest.*"
>
> Review URL: https://codereview.chromium.org/266823002
TBR=peria@chromium.org
Review URL: https://codereview.chromium.org/265093003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267879 0039d316-1c4b-4281-b951-d872f2087c98