| commit | 67ad8b57560679cd2dfc2890c207b645e3a46f49 | |
| author | brettw <brettw@chromium.org> | |
| Mon, 10 Nov 2014 23:30:43 +0000 (10 15:30 -0800) | ||
| committer | Commit bot <commit-bot@chromium.org> | |
| Mon, 10 Nov 2014 23:31:25 +0000 (10 23:31 +0000) | ||
| tree | 74966d5e47e42f88091f5e508ed510bc8bd7c37a | treesnapshot (tar.gz zip) |
| parent | 1bfe82af46f4b885eed03fc4db1baf1bd62ddbd4 | commitdiff |
Ignore non-focusable field while identifying sections in FormStructure.
This also updates the form data comparison functions which did not include many fields. This manifested as a bug on the 15_crbug_53075 where the shipping field is initially hidden. Because this is hidden, this new code did not compute a section split. When you revealed it, the code did not detect that anything changed and used the cached values computed previously, counting it as no split. Accounting for "focusable" as a change in the form makes this compute properly.
Original patch by ziran.sun@samsung.com https://codereview.chromium.org/634563002/ This tweaks the test code from Ziran's patch and adds the "heuristics" tests
BUG=231160,426538
Review URL: https://codereview.chromium.org/678463002
Cr-Commit-Position: refs/heads/master@{#303533}
This also updates the form data comparison functions which did not include many fields. This manifested as a bug on the 15_crbug_53075 where the shipping field is initially hidden. Because this is hidden, this new code did not compute a section split. When you revealed it, the code did not detect that anything changed and used the cached values computed previously, counting it as no split. Accounting for "focusable" as a change in the form makes this compute properly.
Original patch by ziran.sun@samsung.com https://codereview.chromium.org/634563002/ This tweaks the test code from Ziran's patch and adds the "heuristics" tests
BUG=231160,426538
Review URL: https://codereview.chromium.org/678463002
Cr-Commit-Position: refs/heads/master@{#303533}
20 files changed: