GetProfileByUser deprecated and renamed to GetProfileByUserUnsafe.
commit6426834d27b9a13cd72bc4f761b068cd361e8b3c
authordzhioev@chromium.org <dzhioev@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Tue, 12 Aug 2014 17:18:22 +0000 (12 17:18 +0000)
committerdzhioev@chromium.org <dzhioev@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Tue, 12 Aug 2014 17:19:58 +0000 (12 17:19 +0000)
tree7ea8376dbdbd880027e7b2713f5989fe67bf8222
parent8fd578e1a7b142cd10a4387861f05fb9459b69e2
GetProfileByUser deprecated and renamed to GetProfileByUserUnsafe.

Created safe alternative which is called GetProfileByUser.
The plan is to investigate all usages of GetProfileByUserUnsafe one by one and
replace them with a safe version, if possible.
Also warning message added for cases when GetProfileByUserUnsafe returns profile
of a wrong user or signin profile. That will help us to detect suspicious calls
to GetProfileByUserUnsafe while work in progress.

BUG=361528
TBR=yoz,dcheng,agl,dewittj,skuhne,derat

Review URL: https://codereview.chromium.org/445353004

Cr-Commit-Position: refs/heads/master@{#289011}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289011 0039d316-1c4b-4281-b951-d872f2087c98
30 files changed:
chrome/browser/chromeos/drive/drive_notification_manager_factory_browsertest.cc
chrome/browser/chromeos/first_run/first_run.cc
chrome/browser/chromeos/first_run/first_run_controller.cc
chrome/browser/chromeos/login/fake_login_utils.cc
chrome/browser/chromeos/login/saml/saml_browsertest.cc
chrome/browser/chromeos/login/screens/user_image_screen.cc
chrome/browser/chromeos/login/session/user_session_manager.cc
chrome/browser/chromeos/login/supervised/supervised_user_test_base.cc
chrome/browser/chromeos/login/ui/user_adding_screen_browsertest.cc
chrome/browser/chromeos/login/users/avatar/user_image_manager_browsertest.cc
chrome/browser/chromeos/login/users/avatar/user_image_manager_impl.cc
chrome/browser/chromeos/login/users/chrome_user_manager.cc
chrome/browser/chromeos/login/users/multi_profile_user_controller.cc
chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager_policy_browsertest.cc
chrome/browser/chromeos/ownership/owner_settings_service_factory.cc
chrome/browser/chromeos/preferences_browsertest.cc
chrome/browser/chromeos/profiles/profile_helper.cc
chrome/browser/chromeos/profiles/profile_helper.h
chrome/browser/extensions/extension_assets_manager_chromeos.cc
chrome/browser/extensions/extension_garbage_collector_chromeos.cc
chrome/browser/invalidation/profile_invalidation_provider_factory_browsertest.cc
chrome/browser/net/nss_context_chromeos_browsertest.cc
chrome/browser/notifications/message_center_settings_controller.cc
chrome/browser/profiles/profile_manager.cc
chrome/browser/ui/ash/session_state_delegate_chromeos.cc
chrome/browser/ui/ash/system_tray_delegate_chromeos.cc
chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc
chrome/browser/ui/webui/chromeos/login/terms_of_service_screen_handler.cc
chrome/browser/ui/webui/options/chromeos/accounts_options_browsertest.cc
chrome/browser/ui/webui/options/chromeos/shared_options_browsertest.cc