Mac: Give app_shim code a nicer home
commit63829f711468110d04c7464acf92c3e7ab3c13d7
authortapted <tapted@chromium.org>
Wed, 24 Sep 2014 23:50:50 +0000 (24 16:50 -0700)
committerCommit bot <commit-bot@chromium.org>
Wed, 24 Sep 2014 23:51:09 +0000 (24 23:51 +0000)
treef57c59b72f62d1ae05d3fbbd11963d69deeef6aa
parent18112c74cee064411a29cfdc3f3464b653b4a67a
Mac: Give app_shim code a nicer home

App Shims are small .app bundles for Mac, which run in their own
process to provide packaged apps with an OSX Dock icon, using IPC to
communicate with the browser process.

Most of the app_shim code currently lives in src/apps/app_shim, but app
shims are very much a browser feature, so it doesn't belong there. It's
causing DEPS problems for athena efforts.

This CL moves most of apps/app_shim to chrome/browser/apps/app_shim
(c/b/apps didn't exist until a few months after src/apps/app_shim).

The shim itself (i.e. chrome_main_app_mode_mac.mm) doesn't run in the
browser process - it has its own, shim process. Those parts are moved to
a new folder: src/chrome/app_shim, consolidating files currently spread
across src/apps/app_shim and src/chrome/app.

app_shim_launch.h and app_shim_messages.h are used in both the shim
process and the browser process. They're moved to chrome/common/mac.

Summary of changes:
  {apps => chrome/browser/apps}/app_shim/*
except
  {apps => chrome}/app_shim/chrome_main_app_mode_mac.mm
  {apps/app_shim => chrome/common/mac}/app_shim_launch.h
  {apps/app_shim => chrome/common/mac}/app_shim_messages.h
  app_shim.gypi renamed to browser_app_shim.gypi
  chrome/app_shim/app_shim.gypi added
and
  chrome/{app => app_shim}/app_mode-Info.plist
  chrome/{app => app_shim}/app_mode_loader_mac.mm

- apps/app_shim/DEPS now just generated_resources.h
- 'app_mode_app' target moved from chrome.gyp to app_shim.gypi

BUG=266705

Review URL: https://codereview.chromium.org/585123004

Cr-Commit-Position: refs/heads/master@{#296576}
44 files changed:
apps/app_shim/DEPS [deleted file]
apps/app_shim/OWNERS [deleted file]
chrome/app_shim/DEPS [new file with mode: 0644]
chrome/app_shim/OWNERS [new file with mode: 0644]
chrome/app_shim/app_mode-Info.plist [moved from chrome/app/app_mode-Info.plist with 100% similarity]
chrome/app_shim/app_mode_loader_mac.mm [moved from chrome/app/app_mode_loader_mac.mm with 100% similarity]
chrome/app_shim/app_shim.gypi [new file with mode: 0644]
chrome/app_shim/chrome_main_app_mode_mac.mm [moved from apps/app_shim/chrome_main_app_mode_mac.mm with 99% similarity]
chrome/browser/BUILD.gn
chrome/browser/app_controller_mac.mm
chrome/browser/apps/app_shim/OWNERS [new file with mode: 0644]
chrome/browser/apps/app_shim/app_shim_handler_mac.cc [moved from apps/app_shim/app_shim_handler_mac.cc with 98% similarity]
chrome/browser/apps/app_shim/app_shim_handler_mac.h [moved from apps/app_shim/app_shim_handler_mac.h with 93% similarity]
chrome/browser/apps/app_shim/app_shim_host_mac.cc [moved from apps/app_shim/app_shim_host_mac.cc with 95% similarity]
chrome/browser/apps/app_shim/app_shim_host_mac.h [moved from apps/app_shim/app_shim_host_mac.h with 92% similarity]
chrome/browser/apps/app_shim/app_shim_host_mac_unittest.cc [moved from apps/app_shim/app_shim_host_mac_unittest.cc with 98% similarity]
chrome/browser/apps/app_shim/app_shim_host_manager_browsertest_mac.mm [moved from apps/app_shim/app_shim_host_manager_browsertest_mac.mm with 98% similarity]
chrome/browser/apps/app_shim/app_shim_host_manager_mac.h [moved from apps/app_shim/app_shim_host_manager_mac.h with 87% similarity]
chrome/browser/apps/app_shim/app_shim_host_manager_mac.mm [moved from apps/app_shim/app_shim_host_manager_mac.mm with 96% similarity]
chrome/browser/apps/app_shim/app_shim_interactive_uitest_mac.mm [moved from apps/app_shim/app_shim_interactive_uitest_mac.mm with 98% similarity]
chrome/browser/apps/app_shim/app_shim_quit_interactive_uitest_mac.mm [moved from apps/app_shim/app_shim_quit_interactive_uitest_mac.mm with 96% similarity]
chrome/browser/apps/app_shim/browser_app_shim.gypi [moved from apps/app_shim/app_shim.gypi with 67% similarity]
chrome/browser/apps/app_shim/extension_app_shim_handler_mac.cc [moved from apps/app_shim/extension_app_shim_handler_mac.cc with 99% similarity]
chrome/browser/apps/app_shim/extension_app_shim_handler_mac.h [moved from apps/app_shim/extension_app_shim_handler_mac.h with 95% similarity]
chrome/browser/apps/app_shim/extension_app_shim_handler_mac_unittest.cc [moved from apps/app_shim/extension_app_shim_handler_mac_unittest.cc with 99% similarity]
chrome/browser/apps/app_shim/test/app_shim_host_manager_test_api_mac.cc [moved from apps/app_shim/test/app_shim_host_manager_test_api_mac.cc with 80% similarity]
chrome/browser/apps/app_shim/test/app_shim_host_manager_test_api_mac.h [moved from apps/app_shim/test/app_shim_host_manager_test_api_mac.h with 73% similarity]
chrome/browser/apps/app_shim/unix_domain_socket_acceptor.cc [moved from apps/app_shim/unix_domain_socket_acceptor.cc with 97% similarity]
chrome/browser/apps/app_shim/unix_domain_socket_acceptor.h [moved from apps/app_shim/unix_domain_socket_acceptor.h with 89% similarity]
chrome/browser/browser_process_platform_part_mac.h
chrome/browser/chrome_browser_main_mac.mm
chrome/browser/ui/app_list/app_list_service_mac.h
chrome/browser/ui/app_list/app_list_service_mac_interactive_uitest.mm
chrome/browser/ui/cocoa/apps/app_shim_menu_controller_mac.mm
chrome/browser/ui/cocoa/apps/native_app_window_cocoa.mm
chrome/chrome.gyp
chrome/chrome_browser.gypi
chrome/chrome_common.gypi
chrome/chrome_tests.gypi
chrome/chrome_tests_unit.gypi
chrome/common/DEPS
chrome/common/common_message_generator.h
chrome/common/mac/app_shim_launch.h [moved from apps/app_shim/app_shim_launch.h with 91% similarity]
chrome/common/mac/app_shim_messages.h [moved from apps/app_shim/app_shim_messages.h with 98% similarity]