Revert of Cleanup dependencies in web_resource (patchset #3 id:220001 of https:/...
commit62fbe7dbc923be80fcd9579bf975959a2e5148da
authornasko <nasko@chromium.org>
Fri, 21 Aug 2015 17:44:00 +0000 (21 10:44 -0700)
committerCommit bot <commit-bot@chromium.org>
Fri, 21 Aug 2015 17:44:32 +0000 (21 17:44 +0000)
tree3157d43733d49b6ee08bca4124e99ff87ac964e8
parent85ee158b0b95a2db4a1c943016bc956d6a56bd4f
Revert of Cleanup dependencies in web_resource (patchset #3 id:220001 of https://codereview.chromium.org/1288933002/ )

Reason for revert:
This is CL causes flaky failures on the bots:

PromoResourceServiceTest.AppLauncherPromoTest (run #1):
[ RUN      ] PromoResourceServiceTest.AppLauncherPromoTest
../../chrome/browser/web_resource/promo_resource_service_unittest.cc:581: Failure
Value of: promo_test.promo().CanShow()
  Actual: true
Expected: false
[  FAILED  ] PromoResourceServiceTest.AppLauncherPromoTest (1 ms)

http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%281%29/builds/16949
http://build.chromium.org/p/chromium.linux/builders/Linux%20GN/builds/30843

Original issue's description:
> Cleanup dependencies in web_resource
>
> This CL removes the dependencies on channel_info,
> browser_process and content metrics.
> The goal of this work is to enable componentization of this code,
> so that it can be shared on iOS.
>
> notification_promo_helper is introduced so that code in //chrome
> does not have to explicitly pass all the arguments to the static
> methods in NotificationPromo.
> This will also avoid updating all the callsites when future CLs
> add even more arguments.
>
> BUG=371477
> TBR=sky
>
> Committed: https://crrev.com/de37df07399b369ce22c332ac67fb2cce38f739e
> Cr-Commit-Position: refs/heads/master@{#344779}

TBR=rsesek@chromium.org,sky@chromium.org,droger@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=371477

Review URL: https://codereview.chromium.org/1303383002

Cr-Commit-Position: refs/heads/master@{#344809}
14 files changed:
chrome/browser/browser_process_impl.cc
chrome/browser/ui/webui/ntp/new_tab_page_handler.cc
chrome/browser/ui/webui/ntp/ntp_resource_cache.cc
chrome/browser/web_resource/notification_promo.cc
chrome/browser/web_resource/notification_promo.h
chrome/browser/web_resource/notification_promo_helper.cc [deleted file]
chrome/browser/web_resource/notification_promo_helper.h [deleted file]
chrome/browser/web_resource/notification_promo_mobile_ntp.cc
chrome/browser/web_resource/notification_promo_mobile_ntp.h
chrome/browser/web_resource/promo_resource_service.cc
chrome/browser/web_resource/promo_resource_service.h
chrome/browser/web_resource/promo_resource_service_mobile_ntp_unittest.cc
chrome/browser/web_resource/promo_resource_service_unittest.cc
chrome/chrome_browser.gypi