| commit | 62bbc7872309e42dabe93d18358f2819dbf69a6c | |
| author | danakj <danakj@chromium.org> | |
| Fri, 3 Oct 2014 16:45:28 +0000 (3 09:45 -0700) | ||
| committer | Commit bot <commit-bot@chromium.org> | |
| Fri, 3 Oct 2014 16:45:39 +0000 (3 16:45 +0000) | ||
| tree | 21de070920041ba5e9bb1e0fdcef3f50e6460148 | treesnapshot (tar.gz zip) |
| parent | e547cceaf2fba1e7cc26bd283829ad4345ff07d3 | commitdiff |
cc: Fix DCHECK in picture pile.
The DCHECK is trying to say that "If the tile isn't going
to get rerecorded, then it better be fully invalidated."
However the "isn't going to get recorded" part isn't quite
right. It compares the TileBounds to the interest_rect.
But the interest rect is iterated including borders. So
we should use the TileBoundsWithBorders or the
interest_rect_over_tiles to get the right DCHECK.
This uses TileBounds and interest_rect_over_tiles.
R=enne, vmpstr
BUG=418447
Review URL: https://codereview.chromium.org/624973002
Cr-Commit-Position: refs/heads/master@{#298045}
The DCHECK is trying to say that "If the tile isn't going
to get rerecorded, then it better be fully invalidated."
However the "isn't going to get recorded" part isn't quite
right. It compares the TileBounds to the interest_rect.
But the interest rect is iterated including borders. So
we should use the TileBoundsWithBorders or the
interest_rect_over_tiles to get the right DCHECK.
This uses TileBounds and interest_rect_over_tiles.
R=enne, vmpstr
BUG=418447
Review URL: https://codereview.chromium.org/624973002
Cr-Commit-Position: refs/heads/master@{#298045}
| cc/resources/picture_pile.cc | diffblobblamehistory |