Revert of [AppRemoting] Break out AppRemoting shared module (re-land). (patchset...
commit6235553aac7ef07fd1ed55d55490a75bd35af4c5
authorphoglund <phoglund@chromium.org>
Wed, 17 Jun 2015 08:44:33 +0000 (17 01:44 -0700)
committerCommit bot <commit-bot@chromium.org>
Wed, 17 Jun 2015 08:45:04 +0000 (17 08:45 +0000)
tree9c0f770e20ac638d6ac4f9c786fdb905252b0f35
parent55d1267c6702d8fa6ea64df53ad9be1dbb9ec4c2
Revert of [AppRemoting] Break out AppRemoting shared module (re-land). (patchset #2 id:20001 of https://codereview.chromium.org/1179873005/)

Reason for revert:
I believe this broke the linux GN clobber build:
https://build.chromium.org/p/chromium.linux/builders/Linux%20GN%20Clobber/builds/1309/steps/compile/logs/stdio

Traceback (most recent call last):
  File "../../remoting/webapp/build-webapp.py", line 487, in <module>
    sys.exit(main())
  File "../../remoting/webapp/build-webapp.py", line 483, in main
    return buildWebApp(**vars(args))
  File "../../remoting/webapp/build-webapp.py", line 257, in buildWebApp
    + buildtype + ': ' + service_environment)
Exception: Invalid service_environment targeted for Release:
ninja: build stopped: subcommand failed.

Original issue's description:
> [AppRemoting] Break out AppRemoting shared module.
>
> This is a reland of crrev.com/1176143002 with missing files added:
>   remoting/webapp/app_remoting/shared_module/manifest.json
>
> This cl breaks out the shared AppRemoting code into a shared module so
> that it does not need to be duplicated in each individual app.
>
> This version has the following limitations which will be addressed in
> follow-up cls:
> (1) The apps have a hard-coded reference to the dev shared module
> (2) The apps have a hard-coded reference to the dev orchestrator
> (3) The resources in the app stub should be replaced with empty stub
>     resources rather than a copy of all the shared resources.
> (4) The shared module is only built in GN (not GYP)
>
> BUG=
>
> Committed: https://crrev.com/5b696cf0d943d03a7bd388bdca1ffc6d95d3fc9c
> Cr-Commit-Position: refs/heads/master@{#334708}

TBR=kelvinp@chromium.org,thestig@chromium.org,garykac@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/1191883002

Cr-Commit-Position: refs/heads/master@{#334791}
31 files changed:
remoting/app_remoting_webapp.gyp
remoting/app_remoting_webapp_build.gypi
remoting/app_remoting_webapp_files.gypi
remoting/remoting_options.gni
remoting/remoting_webapp_files.gypi
remoting/webapp/BUILD.gn
remoting/webapp/app_remoting/html/context_menu.html
remoting/webapp/app_remoting/html/template_background.html [deleted file]
remoting/webapp/app_remoting/html/template_feedback_consent.html
remoting/webapp/app_remoting/html/template_lg.html
remoting/webapp/app_remoting/html/template_loading_window.html
remoting/webapp/app_remoting/js/app_remoting.js
remoting/webapp/app_remoting/js/app_remoting_activity.js
remoting/webapp/app_remoting/js/application_context_menu.js
remoting/webapp/app_remoting/js/ar_background.js
remoting/webapp/app_remoting/js/ar_main.js [moved from remoting/webapp/app_remoting/vendor/arv_main.js with 57% similarity]
remoting/webapp/app_remoting/js/feedback_consent.js
remoting/webapp/app_remoting/manifest_common.json.jinja2
remoting/webapp/app_remoting/shared_module/manifest.json [deleted file]
remoting/webapp/app_remoting/vendor/arv_background.html [deleted file]
remoting/webapp/app_remoting/vendor/arv_main.html [deleted file]
remoting/webapp/app_remoting/vendor/arv_wcs_sandbox.html [deleted file]
remoting/webapp/base/js/app_capabilities.js [new file with mode: 0644]
remoting/webapp/base/js/application.js
remoting/webapp/base/js/message_window_helper.js
remoting/webapp/base/js/plugin_settings.js
remoting/webapp/build-webapp.py
remoting/webapp/build_template.gni
remoting/webapp/crd/js/desktop_remoting.js
remoting/webapp/crd/js/desktop_remoting_activity.js
remoting/webapp/files.gni