| commit | 61f5ad7107405f414b1b14ddff712388ecece98c | |
| author | jam <jam@chromium.org> | |
| Fri, 11 Sep 2015 17:06:57 +0000 (11 10:06 -0700) | ||
| committer | Commit bot <commit-bot@chromium.org> | |
| Fri, 11 Sep 2015 17:07:50 +0000 (11 17:07 +0000) | ||
| tree | 0d730318577053ff0621546aeb6d617a4fd508bd | treesnapshot (tar.gz zip) |
| parent | 9596af87332d84672d61025725395deb7870f328 | commitdiff |
Revert of Try changing LockImpl to not have a spin count to see how it affects performance. (patchset #1 id:1 of https://codereview.chromium.org/1333053002/ )
Reason for revert:
didn't make any difference
Original issue's description:
> Try changing LockImpl to not have a spin count to see how it affects performance.
>
> This was last change 7 years ago, and we have grown a lot of usages of locks since then. Since we don't use pthread_spin_lock on posix, I'm curious how this affects performance today on Windows.
>
> Committed: https://crrev.com/00c9ca679badffc7584439fff00f18cb3977d5da
> Cr-Commit-Position: refs/heads/master@{#348280}
TBR=cpu@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/1340653003
Cr-Commit-Position: refs/heads/master@{#348417}
Reason for revert:
didn't make any difference
Original issue's description:
> Try changing LockImpl to not have a spin count to see how it affects performance.
>
> This was last change 7 years ago, and we have grown a lot of usages of locks since then. Since we don't use pthread_spin_lock on posix, I'm curious how this affects performance today on Windows.
>
> Committed: https://crrev.com/00c9ca679badffc7584439fff00f18cb3977d5da
> Cr-Commit-Position: refs/heads/master@{#348280}
TBR=cpu@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/1340653003
Cr-Commit-Position: refs/heads/master@{#348417}
| base/synchronization/lock_impl_win.cc | diffblobblamehistory |