| commit | 5eefc8b5665c30573bddfec1cecd561e57f60823 | |
| author | rob <rob@robwu.nl> | |
| Fri, 9 Jan 2015 12:38:50 +0000 (9 04:38 -0800) | ||
| committer | Commit bot <commit-bot@chromium.org> | |
| Fri, 9 Jan 2015 12:39:38 +0000 (9 12:39 +0000) | ||
| tree | 7ecce95dc0ab276c1a1127257c3ba43eb039e511 | treesnapshot (tar.gz zip) |
| parent | 4eeca3a20fca6bbb9d048895cac1b2c540b3f01d | commitdiff |
Close embedded extension options page when the overlay is hidden
Previously, when the embedded extension options page was hidden through
an unexpected event (i.e. not via Esc or via the Close button, but via
a script, e.g. by bug 445918), the extension options page would not be
removed even though it was hidden.
This patch fixes the problem by triggering the page destruction handlers
(ExtensionOptionsOverlay.prototype.handleDismiss_) via the cancelOverlay
event.
BUG=445978
R=finnur@chromium.org
Review URL: https://codereview.chromium.org/831063002
Cr-Commit-Position: refs/heads/master@{#310763}
Previously, when the embedded extension options page was hidden through
an unexpected event (i.e. not via Esc or via the Close button, but via
a script, e.g. by bug 445918), the extension options page would not be
removed even though it was hidden.
This patch fixes the problem by triggering the page destruction handlers
(ExtensionOptionsOverlay.prototype.handleDismiss_) via the cancelOverlay
event.
BUG=445978
R=finnur@chromium.org
Review URL: https://codereview.chromium.org/831063002
Cr-Commit-Position: refs/heads/master@{#310763}
| chrome/browser/resources/extensions/extensions.js | diffblobblamehistory |