Revert of Enable ASan default options on Mac. (patchset #4 id:60001 of https://codere...
commit5ed6fe035890a10288da3b99b2b46a7680b4636f
authorglider <glider@chromium.org>
Mon, 22 Sep 2014 16:34:48 +0000 (22 09:34 -0700)
committerCommit bot <commit-bot@chromium.org>
Mon, 22 Sep 2014 16:35:25 +0000 (22 16:35 +0000)
tree9763bd41adcff5b4063a9abadb7d0c6cf89ae6bc
parent685ccea874df9b5f47665aac007bbc876d344938
Revert of Enable ASan default options on Mac. (patchset #4 id:60001 of https://codereview.chromium.org/581983003/)

Reason for revert:
This CL broke ui_unittests on both Mac ASan and Mac ASan 64 bots:

/Volumes/data/bool/build/slave/Mac_ASan_Tests__2_/build/src/out/Release/ui_unittests --brave-new-test-launcher --test-launcher-bot-mode --verbose --test-launcher-print-test-stdio=always --gtest_print_time --test-launcher-summary-output=/tmp/tmpnPVxX8
dyld: Library not loaded: @executable_path/../Versions/1.0.0.0/ui_unittests Framework.framework/ui_unittests Framework
  Referenced from: /Volumes/data/bool/build/slave/Mac_ASan_Tests__2_/build/src/out/Release/ui_unittests
  Reason: image not found

http://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%20Tests%20%282%29/builds/5393/steps/ui_unittests/logs/stdio

Original issue's description:
> Enable ASan default options on Mac.
>
> This CL links libsanitizer_options into every executable built with ASan on OSX.
> The existing implementation of __asan_default_options for Chromium.app is merged with that in sanitizer_options.cc
>
> Also now use_sanitizer_options is only set when building with sanitizers so that there isn't an unconditional dependency on an empty object file in every executable in non-sanitizer builds.
>
> BUG=302040
> R=cpu@chromium.org
>
> Committed: https://crrev.com/0640a5d19ef72aec62787423e8a7c78c4f62b955
> Cr-Commit-Position: refs/heads/master@{#295958}

TBR=cpu@chromium.org,earthdok@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=302040

Review URL: https://codereview.chromium.org/593683004

Cr-Commit-Position: refs/heads/master@{#295987}
build/common.gypi
build/sanitizers/sanitizer_options.cc
build/sanitizers/sanitizers.gyp
chrome/app/chrome_exe_main_mac.cc
chrome/app/framework.order