Revert of [Media Router] Design MediaRouter interface with stub implementation. ...
commit5d6b8901b921b70dccd445ba5cabfaf99c3f6414
authorsorin <sorin@chromium.org>
Fri, 10 Apr 2015 01:11:53 +0000 (9 18:11 -0700)
committerCommit bot <commit-bot@chromium.org>
Fri, 10 Apr 2015 01:12:18 +0000 (10 01:12 +0000)
treedeb2356118e6cbc0acc0d5e7c6b4d5a4a795e18e
parentb69390365c56bb0c234934a435731430050dd770
Revert of [Media Router] Design MediaRouter interface with stub implementation. (patchset #27 id:590001 of https://codereview.chromium.org/1020743003/)

Reason for revert:
Suspecting it breaks building unit_tests_main on Mac GN and Win8 GN

http://build.chromium.org/p/chromium.win/builders/Win8%20GN/builds/6186

FAILED: E:/b/depot_tools/python276_bin/python.exe gyp-win-tool link-wrapper environment.x86 False link.exe /nologo /OUT:unit_tests_main.exe /PDB:unit_tests_main.exe.pdb @unit_tests_main.exe.rsp
browser.browser_ppapi_host_impl.obj : error LNK2019: unresolved external symbol "public: __thiscall ppapi::host::PpapiHost::PpapiHost(class IPC::Sender *,class ppapi::PpapiPermissions const &)" (??0PpapiHost@host@ppapi@@QAE@PAVSender@IPC@@ABVPpapiPermissions@2@@Z) referenced in function "public: __thiscall content::BrowserPpapiHostImpl::BrowserPpapiHostImpl(class IPC::Sender *,class ppapi::PpapiPermissions const &,class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,class base::FilePath const &,class base::FilePath const &,bool,bool)" (??0BrowserPpapiHostImpl@content@@QAE@PAVSender@IPC@@ABVPpapiPermissions@ppapi@@ABV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@ABVFilePath@base@@3_N4@Z)

browser.browser_ppapi_host_impl.obj : error LNK2019: unresolved external symbol "public: void __thiscall ppapi::host::PpapiHost::AddHostFactoryFilter(class scoped_ptr<class ppapi::host::HostFactory,struct base::DefaultDeleter<class ppapi::host::HostFactory> >)" (?AddHostFactoryFilter@PpapiHost@host@ppapi@@QAEXV?$scoped_ptr@VHostFactory@host@ppapi@@U?$DefaultDeleter@VHostFactory@host@ppapi@@@base@@@@@Z) referenced in function "public: __thiscall content::BrowserPpapiHostImpl::BrowserPpapiHostImpl(class IPC::Sender *,class ppapi::PpapiPermissions const &,class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,class base::FilePath const &,class base::FilePath const &,bool,bool)" (??0BrowserPpapiHostImpl@content@@QAE@PAVSender@IPC@@ABVPpapiPermissions@ppapi@@ABV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@ABVFilePath@base@@3_N4@Z)

browser.pepper_tcp_socket_message_filter.obj : error LNK2001: unresolved external symbol "public: static void __cdecl ppapi::host::internal::ResourceMessageFilterDeleteTraits::Destruct(class ppapi::host::ResourceMessageFilter const *)" (?Destruct@ResourceMessageFilterDeleteTraits@internal@host@ppapi@@SAXPBVResourceMessageFilter@34@@Z)

browser.pepper_truetype_font_list_host.obj : error LNK2001: unresolved external symbol "public: static void __cdecl ppapi::host::internal::ResourceMessageFilterDeleteTraits::Destruct(class ppapi::host::ResourceMessageFilter const *)" (?Destruct@ResourceMessageFilterDeleteTraits@internal@host@ppapi@@SAXPBVResourceMessageFilter@34@@Z)

browser.pepper_udp_socket_message_filter.obj : error LNK2001: unresolved external symbol "public: static void __cdecl ppapi::host::internal::ResourceMessageFilterDeleteTraits::Destruct(class ppapi::host::ResourceMessageFilter const *)" (?Destruct@ResourceMessageFilterDeleteTraits@internal@host@ppapi@@SAXPBVResourceMessageFilter@34@@Z)

=======================

FAILED: /Volumes/data/b/build/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -arch x86_64 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.6.sdk -mmacosx-version-min=10.6 -Wl,-search_paths_first -L. -Wl,-rpath,@loader_path/. -Wl,-rpath,@loader_path/../../.. -Wl,-pie -o ./unit_tests_main -Wl,-filelist,./unit_tests_main.rsp ./libffmpegsumo.dylib -framework AppKit -framework ApplicationServices -framework Carbon -framework CoreFoundation -framework Foundation -framework IOKit -framework Security -framework QuartzCore -framework SystemConfiguration -lresolv -framework Accelerate -framework AudioUnit -framework CoreVideo -framework Cocoa -framework IOSurface -framework OpenGL -framework CoreMIDI -framework QTKit -framework AudioToolbox -framework CoreAudio -lbsm -framework IOBluetooth
Undefined symbols for architecture x86_64:
  "SuddenMotionSensor::ReadSensorValues(float*)", referenced from:
      (anonymous namespace)::FetchOrientation(SuddenMotionSensor*, content::SharedMemorySeqLockBuffer<blink::WebDeviceOrientationData>*) in browser.data_fetcher_shared_memory_mac.o
      (anonymous namespace)::FetchMotion(SuddenMotionSensor*, content::SharedMemorySeqLockBuffer<blink::WebDeviceMotionData>*) in browser.data_fetcher_shared_memory_mac.o
  "SuddenMotionSensor::Create()", referenced from:
      content::DataFetcherSharedMemory::Start(content::ConsumerType, void*) in browser.data_fetcher_shared_memory_mac.o
  "SuddenMotionSensor::~SuddenMotionSensor()", referenced from:
      base::DefaultDeleter<SuddenMotionSensor>::operator()(SuddenMotionSensor*) const in browser.data_fetcher_shared_memory_mac.o
  "aura::WindowEventDispatcher::HoldPointerMoves()", referenced from:
      content::CompositorResizeLock::CompositorResizeLock(aura::WindowTreeHost*, gfx::Size, bool, base::TimeDelta const&) in browser.compositor_resize_lock_aura.o
  "aura::WindowEventDispatcher::ReleasePointerMoves()", referenced from:
      content::CompositorResizeLock::CancelLock() in browser.compositor_resize_lock_aura.o
  "blink::OpenTypeVerticalData::OpenTypeVerticalData(blink::FontPlatformData const&)", referenced from:
      blink::OpenTypeVerticalData::create(blink::FontPlatformData const&) in blink_platform.FontCache.o

Original issue's description:
> [Media Router] MediaRouter interfaces with stub implementations.
>
> - Updated Media Router data classes.
> - Added MediaRouteResponse class.
> - Added MediaRouteProviderManagerHost interface.
> - Added MediaRouter interface with a stub MediaRouterImpl class.
> - MRImpl are is a KeyedService and is instantiated via
>   its BrowserContextKeyedServiceFactory implementation.
> - Added MediaRoutesObserver / MediaSinksObserver interfaces which are
>   used by MediaRouter API.
>
> BUG=461815,464199
>
> Committed: https://crrev.com/45aa4cbbb775de85003187a8b1371d7922dc0194
> Cr-Commit-Position: refs/heads/master@{#324541}

TBR=kmarshall@chromium.org,mfoltz@chromium.org,imcheng@chromium.org,xhwang@chromium.org,marshallk@google.com,imcheng@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=461815,464199

Review URL: https://codereview.chromium.org/1077963002

Cr-Commit-Position: refs/heads/master@{#324557}
17 files changed:
chrome/browser/media/router/BUILD.gn
chrome/browser/media/router/media_route.h
chrome/browser/media/router/media_router.gyp
chrome/browser/media/router/media_router.h [deleted file]
chrome/browser/media/router/media_router_impl.cc [deleted file]
chrome/browser/media/router/media_router_impl.h [deleted file]
chrome/browser/media/router/media_router_impl_factory.cc [deleted file]
chrome/browser/media/router/media_router_impl_factory.h [deleted file]
chrome/browser/media/router/media_routes_observer.cc [deleted file]
chrome/browser/media/router/media_routes_observer.h [deleted file]
chrome/browser/media/router/media_sink.cc
chrome/browser/media/router/media_sink.h
chrome/browser/media/router/media_sink_unittest.cc
chrome/browser/media/router/media_sinks_observer.cc [deleted file]
chrome/browser/media/router/media_sinks_observer.h [deleted file]
chrome/browser/media/router/media_source.cc
chrome/browser/media/router/media_source.h