| commit | 5a36760990918e47c63d9c19471aab229f566b3d | |
| author | zea <zea@chromium.org> | |
| Thu, 2 Apr 2015 01:11:04 +0000 (1 18:11 -0700) | ||
| committer | Commit bot <commit-bot@chromium.org> | |
| Thu, 2 Apr 2015 01:12:08 +0000 (2 01:12 +0000) | ||
| tree | 5dfe480798a4980edaae5dcd0c779bb7edcfbdc9 | treesnapshot (tar.gz zip) |
| parent | 9faf912c9b5e7135630e2ccb7fbfe4e451d66a77 | commitdiff |
[Sync] Fix undeletion during commit logic
We were relying on the SYNCING bit to track whether a commit has begun or not.
This will not work in all cases, as any modification actually unsets the
SYNCING bit, thereby making it unreliable as a source for whether a sync cycle
has started for an entity. To fix that, introduce a new DIRTY_SYNC bit that
is only modified when a entry becomes dirty during a sync cycle. SYNCING can
then better match it's name, and will stay true until the sync cycle ends.
BUG=466098
TEST=repeatedly bookmark a page then remove the bookmark
Review URL: https://codereview.chromium.org/1048933003
Cr-Commit-Position: refs/heads/master@{#323388}
We were relying on the SYNCING bit to track whether a commit has begun or not.
This will not work in all cases, as any modification actually unsets the
SYNCING bit, thereby making it unreliable as a source for whether a sync cycle
has started for an entity. To fix that, introduce a new DIRTY_SYNC bit that
is only modified when a entry becomes dirty during a sync cycle. SYNCING can
then better match it's name, and will stay true until the sync cycle ends.
BUG=466098
TEST=repeatedly bookmark a page then remove the bookmark
Review URL: https://codereview.chromium.org/1048933003
Cr-Commit-Position: refs/heads/master@{#323388}