Revert of aura: Require explicit ownership of the Env instance. (patchset #7 id:12000...
commit58ea5a7a5598d0709aaf3a3b7cbd0b850b860b5c
authorfsamuel <fsamuel@chromium.org>
Tue, 18 Aug 2015 22:46:11 +0000 (18 15:46 -0700)
committerCommit bot <commit-bot@chromium.org>
Tue, 18 Aug 2015 22:46:48 +0000 (18 22:46 +0000)
treeeb54ec884ff978c1d8952a2282acc533f9165e51
parentec1130acd16944e2f7235acfcbdec64c626253a2
Revert of aura: Require explicit ownership of the Env instance. (patchset #7 id:120001 of https://codereview.chromium.org/1293013002/ )

Reason for revert:
This broke mandoline --enable-multiprocess on Linux:

[0818/183133:FATAL:x11_event_source.cc(80)] Check failed: display_.

Original issue's description:
> aura: Require explicit ownership of the Env instance.
>
> Notable changes:
> . Change aura::Env::CreateInstance() to return a scoped_ptr<> to the aura::Env instance,
>   so that there's a clear owner of the instance, and random code can no longer destroy
>   it.
> . Make aura::Env::CreateInstance() fail if more than one instance is attempted to be
>   created.
> . Remove the boolean parameter to aura::Env::CreateInstance(), since that is no longer
>   necessary, and always create a PlatformEventSource instance (if one hasn't already
>   been created).
> . BrowserMainLoop takes care of creating/destroying the aura::Env instance. So the
>   various BrowserMainParts implementations no longer need to do that.
>
> BUG=none
> TBR=ben@chromium.org as top-level owner for API change updates.
>
> Committed: https://crrev.com/535b77f94d63736b21583c76e2dbf1f2a75e6377
> Cr-Commit-Position: refs/heads/master@{#344037}

TBR=sky@chromium.org,ben@chromium.org,sadrul@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=none

Review URL: https://codereview.chromium.org/1297173003

Cr-Commit-Position: refs/heads/master@{#344058}
29 files changed:
ash/shell/content_client/shell_browser_main_parts.cc
ash/test/ash_interactive_ui_test_base.cc
ash/test/ash_interactive_ui_test_base.h
ash/test/test_suite.cc
ash/test/test_suite.h
chrome/test/base/view_event_test_platform_part_ash.cc
chrome/test/base/view_event_test_platform_part_chromeos.cc
chromecast/browser/cast_browser_main_parts.cc
content/browser/browser_main_loop.cc
content/browser/browser_main_loop.h
content/public/test/unittest_test_suite.cc
content/public/test/unittest_test_suite.h
content/shell/browser/shell_aura.cc
content/shell/browser/shell_views.cc
mandoline/ui/aura/aura_init.cc
mandoline/ui/aura/aura_init.h
ui/aura/bench/bench_main.cc
ui/aura/demo/demo_main.cc
ui/aura/env.cc
ui/aura/env.h
ui/aura/test/aura_test_helper.cc
ui/aura/test/aura_test_helper.h
ui/aura/test/run_all_unittests.cc
ui/views/examples/examples_main.cc
ui/views/run_all_unittests.cc
ui/views_content_client/views_content_client_main_parts_aura.cc
ui/views_content_client/views_content_client_main_parts_desktop_aura.cc
ui/wm/test/run_all_unittests.cc
ui/wm/test/wm_test_helper.cc