Revert 273547 "Reset scoped_ptr to make plugin crash before ente..."
commit55b5d15b3d371a85b9cbbb4cecd42d751949c820
authorvitalybuka@chromium.org <vitalybuka@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Wed, 4 Jun 2014 17:26:52 +0000 (4 17:26 +0000)
committervitalybuka@chromium.org <vitalybuka@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Wed, 4 Jun 2014 17:26:52 +0000 (4 17:26 +0000)
tree63d3e8aebd55c955718e177b0319bc218f8957ea
parent68c88b0f0a645ac90365686f82edb5cb5580c2e9
Revert 273547 "Reset scoped_ptr to make plugin crash before ente..."

> Reset scoped_ptr to make plugin crash before entering engine_->HandleDocumentLoad, if called for deleted "Instance".
> Suspecting method call for deleted instance.
>
> Example to explain why reset() makes difference:
>
> scoped_ptr<int>* pt = NULL;
> {
>   scoped_ptr<int> t(new int);
>   pt = &t;
> }
> DCHECK(!(*pt));  // Fail
> {
>   scoped_ptr<int> t(new int);
>   pt = &t;
>   t.reset();
> }
> DCHECK(!(*pt)); // OK
>
> BUG=372095,372548
>
> Review URL: https://codereview.chromium.org/300403002

TBR=vitalybuka@chromium.org

Review URL: https://codereview.chromium.org/318743003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274854 0039d316-1c4b-4281-b951-d872f2087c98
pdf/instance.cc