| commit | 53fa469ebff50fdd61ddc2bcf0b37d29b22f577f | |
| author | vabr@chromium.org <vabr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Tue, 15 Apr 2014 17:09:04 +0000 (15 17:09 +0000) | ||
| committer | vabr@chromium.org <vabr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Tue, 15 Apr 2014 17:09:04 +0000 (15 17:09 +0000) | ||
| tree | 360e52328c72d7c62b039a259e239981f64e2efe | treesnapshot (tar.gz zip) |
| parent | 03497d914bc5811fc5f9ac96f266db7305461510 | commitdiff |
Password manager: pass pending credentials by a const ref, not copy
ManagePasswordsBubbleUIController::pending_credentials and PasswordFormManager::Pending_Credentials currently return a const PasswordForm by value. This CL makes them return a const ref, to avoid keeping a reference to a temporary object anywhere in the code.
BUG=363061
Review URL: https://codereview.chromium.org/238683006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263897 0039d316-1c4b-4281-b951-d872f2087c98
ManagePasswordsBubbleUIController::pending_credentials and PasswordFormManager::Pending_Credentials currently return a const PasswordForm by value. This CL makes them return a const ref, to avoid keeping a reference to a temporary object anywhere in the code.
BUG=363061
Review URL: https://codereview.chromium.org/238683006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263897 0039d316-1c4b-4281-b951-d872f2087c98
| chrome/browser/ui/passwords/manage_passwords_bubble_ui_controller.h | diffblobblamehistory | |
| components/password_manager/core/browser/password_form_manager.h | diffblobblamehistory |