Sort page actions before comparing them to the list of page action views
commit5235011aa967a55221029e0558b8b7ce86bc88a4
authorrfevang <rfevang@chromium.org>
Thu, 12 Mar 2015 21:08:19 +0000 (12 14:08 -0700)
committerCommit bot <commit-bot@chromium.org>
Thu, 12 Mar 2015 21:08:57 +0000 (12 21:08 +0000)
treea45671518813a5053bf7a27f33bb6f2c87e0ab64
parenta8fb649c0310199808ae6811bc76378d466f1948
Sort page actions before comparing them to the list of page action views

This fixes an issue where PageActionDiffer would report differences on
every call if the external bookmark manager was installed and the user
had any other extension with a page action and an id preceding that of
the bookmark manager. This would cause the page action UI elements to be
constantly destroyed and rebuilt.

BUG=465595,465449

Review URL: https://codereview.chromium.org/993063003

Cr-Commit-Position: refs/heads/master@{#320371}
chrome/browser/extensions/location_bar_controller.cc
chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm
chrome/browser/ui/views/location_bar/location_bar_view.cc