Standardize usage of virtual/override/final specifiers in sync/.
commit520ae85e967f776f4134277cb14e487894421226
authordcheng <dcheng@chromium.org>
Mon, 22 Dec 2014 22:40:24 +0000 (22 14:40 -0800)
committerCommit bot <commit-bot@chromium.org>
Mon, 22 Dec 2014 22:41:02 +0000 (22 22:41 +0000)
tree509299de71fd5d8cba15fe5758a495fd86898524
parentdf1702e8aa43e3996d64c0988e48612a5fad4624
Standardize usage of virtual/override/final specifiers in sync/.

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

Several formatting edits by clang-format were manually reverted, due to
mangling of some of the more complicate IPC macros.

BUG=417463

Review URL: https://codereview.chromium.org/792343004

Cr-Commit-Position: refs/heads/master@{#309474}
32 files changed:
sync/api/syncable_service.h
sync/engine/apply_control_data_updates_unittest.cc
sync/engine/directory_commit_contribution_unittest.cc
sync/engine/directory_update_handler_unittest.cc
sync/engine/entity_tracker_unittest.cc
sync/engine/get_updates_processor_unittest.cc
sync/engine/model_type_sync_proxy_impl_unittest.cc
sync/engine/model_type_sync_worker_impl_unittest.cc
sync/engine/sync_scheduler_unittest.cc
sync/engine/syncer_proto_util_unittest.cc
sync/engine/syncer_unittest.cc
sync/engine/syncer_util_unittest.cc
sync/internal_api/attachments/attachment_downloader_impl_unittest.cc
sync/internal_api/attachments/attachment_service_impl_unittest.cc
sync/internal_api/attachments/attachment_service_proxy_unittest.cc
sync/internal_api/attachments/attachment_store_handle_unittest.cc
sync/internal_api/attachments/attachment_uploader_impl_unittest.cc
sync/internal_api/attachments/fake_attachment_downloader_unittest.cc
sync/internal_api/attachments/fake_attachment_uploader_unittest.cc
sync/internal_api/http_bridge_unittest.cc
sync/internal_api/protocol_event_buffer_unittest.cc
sync/internal_api/public/base/cancelation_signal_unittest.cc
sync/internal_api/public/util/weak_handle_unittest.cc
sync/internal_api/sync_context_proxy_impl_unittest.cc
sync/internal_api/sync_manager_impl_unittest.cc
sync/internal_api/sync_rollback_manager_base_unittest.cc
sync/sessions/model_type_registry_unittest.cc
sync/syncable/deferred_on_disk_directory_backing_store_unittest.cc
sync/syncable/directory_backing_store_unittest.cc
sync/syncable/directory_unittest.h
sync/syncable/parent_child_index_unittest.cc
sync/syncable/syncable_unittest.cc