| commit | 5192601b41aff92488b9a458fc50dedda48507ac | |
| author | dongseong.hwang <dongseong.hwang@intel.com> | |
| Wed, 4 Feb 2015 13:30:28 +0000 (4 05:30 -0800) | ||
| committer | Commit bot <commit-bot@chromium.org> | |
| Wed, 4 Feb 2015 13:32:43 +0000 (4 13:32 +0000) | ||
| tree | 355eec0ca4f4ab5cf8e5483b875d707632eadc1e | treesnapshot (tar.gz zip) |
| parent | d3dd7390552c77952ed24a6f3e9100728cef1191 | commitdiff |
Fix componene debug build failure because of src/media/blink
The error log is as follows:
../../third_party/skia/include/core/SkImageInfo.h:109: error: undefined reference to 'SkDebugf_FileLine(char const*, int, bool, char const*, ...)'
collect2: error: ld returned 1 exit status
If any modules are going to use any Skia header no matter whether directly or
indirectly, the module must link Skia. src/media/blink doesn't depend on skia
directly but src/media, on which src/media/blink depends, depends on Skia. So
src/media/blink must link to Skia.
Review URL: https://codereview.chromium.org/885373003
Cr-Commit-Position: refs/heads/master@{#314554}
The error log is as follows:
../../third_party/skia/include/core/SkImageInfo.h:109: error: undefined reference to 'SkDebugf_FileLine(char const*, int, bool, char const*, ...)'
collect2: error: ld returned 1 exit status
If any modules are going to use any Skia header no matter whether directly or
indirectly, the module must link Skia. src/media/blink doesn't depend on skia
directly but src/media, on which src/media/blink depends, depends on Skia. So
src/media/blink must link to Skia.
Review URL: https://codereview.chromium.org/885373003
Cr-Commit-Position: refs/heads/master@{#314554}
| media/blink/BUILD.gn | diffblobblamehistory | |
| media/blink/media_blink.gyp | diffblobblamehistory |