Revert of ui: Add another presubmit check to catch two more scoped_ptr usages. (patch...
commit511f02da1423bf3a8e365a88ddf77b676f6998d0
authorscottmg <scottmg@chromium.org>
Tue, 24 Feb 2015 00:21:17 +0000 (23 16:21 -0800)
committerCommit bot <commit-bot@chromium.org>
Tue, 24 Feb 2015 00:21:53 +0000 (24 00:21 +0000)
tree520a8a63818b9739be88da6bef1e6e8c477bc95c
parentbdbf3b186bc3fc0a1101b0571af80254fac9948f
Revert of ui: Add another presubmit check to catch two more scoped_ptr usages. (patchset #6 id:100001 of https://codereview.chromium.org/919253002/)

Reason for revert:
Presubmit in ui/ failing with

...
File "<string>", line 38, in CheckScopedPtr
NameError: global name 're' is not defined

Original issue's description:
> ui: Add another presubmit check to catch two more scoped_ptr usages.
>
> This should catch the following usages:
>
> 1- return scoped_ptr<T>(foo)
> 2- bar = scoped_ptr<T>(foo)
>
> And recommend the solo usage of make_scoped_ptr().
>
> The entries were found with the following command line:
>
> $ git grep -E '(=|\breturn)\s*scoped_ptr<.*?>([^)]+)'
>
> BUG=None
> TEST=g cl presubmit -uv
> R=sky@chromium.org,maruel@chromium.org
>
> Committed: https://crrev.com/63f25bef305bd8143766e2e1a98bf01548c78376
> Cr-Commit-Position: refs/heads/master@{#317669}

TBR=maruel@chromium.org,sky@chromium.org,maruel@google.com,sadrul@chromium.org,tfarina@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=None

Review URL: https://codereview.chromium.org/954473003

Cr-Commit-Position: refs/heads/master@{#317686}
ui/PRESUBMIT.py