Revert of Mandoline filesystem: Enable windows build. (patchset #8 id:140001 of https...
commit50d829befd7b63ec3e70e4b4373a05564aa07547
authorerg <erg@chromium.org>
Fri, 29 May 2015 23:30:32 +0000 (29 16:30 -0700)
committerCommit bot <commit-bot@chromium.org>
Fri, 29 May 2015 23:30:58 +0000 (29 23:30 +0000)
treeaa80de493419d64c3233e8202181dc6a593f0c82
parentebfc444fa8d483287f1927da04fafcff1f4f7f76
Revert of Mandoline filesystem: Enable windows build. (patchset #8 id:140001 of https://codereview.chromium.org/1163713002/)

Reason for revert:
Patch failed on Win 8 GN:

FAILED: ninja -t msvc -e environment.x64 -- E:\b\build\goma/gomacc.exe "E:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64/cl.exe" /nologo /showIncludes /FC @obj/components/filesystem/filesystem_library.file_impl.obj.rsp /c ../../components/filesystem/file_impl.cc /Foobj/components/filesystem/filesystem_library.file_impl.obj /Fdobj/components/filesystem/filesystem_library_cc.pdb
e:\b\build\slave\win_x64_gn\build\src\components\filesystem\file_impl.cc(129) : error C2220: warning treated as error - no 'object' file generated
e:\b\build\slave\win_x64_gn\build\src\components\filesystem\file_impl.cc(129) : warning C4267: 'argument' : conversion from 'size_t' to 'int', possible loss of data

Original issue's description:
> Mandoline filesystem: Build the filesystem on windows.
>
> This resolves name collisions with #defines in windows.h and does os specific path handling in a few places.
>
> BUG=490237
>
> Committed: https://crrev.com/3e8be89d1827aed47a9deeb7d1b6745258c17000
> Cr-Commit-Position: refs/heads/master@{#332073}

TBR=sky@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=490237

Review URL: https://codereview.chromium.org/1163523006

Cr-Commit-Position: refs/heads/master@{#332075}
13 files changed:
components/filesystem/directory_impl.cc
components/filesystem/directory_impl_unittest.cc
components/filesystem/file_impl.cc
components/filesystem/file_impl_unittest.cc
components/filesystem/file_system_impl.cc
components/filesystem/files_test_base.cc
components/filesystem/public/interfaces/directory.mojom
components/filesystem/public/interfaces/file.mojom
components/filesystem/public/interfaces/file_system.mojom
components/filesystem/public/interfaces/types.mojom
components/filesystem/util.cc
components/filesystem/util.h
mandoline/BUILD.gn