| commit | 507054ccac1778eace34f76afd40ade6e855d6fc | |
| author | erikchen <erikchen@chromium.org> | |
| Wed, 17 Sep 2014 19:28:34 +0000 (17 12:28 -0700) | ||
| committer | Commit bot <commit-bot@chromium.org> | |
| Wed, 17 Sep 2014 19:28:45 +0000 (17 19:28 +0000) | ||
| tree | a97cee7cd8fd4b1cbfca9e1fe84553632f33324c | treesnapshot (tar.gz zip) |
| parent | 7358b28dfed17b646706b163de3aea0454f80b2b | commitdiff |
Mac: Fix accidental changes to fullscreen logic from refactor.
The menu item "Enter Presentation Mode" has different effects in 10.6 and
10.7+. In 10.6, the menu item invokes Immersive Fullscreen. In 10.7+, the menu
item invokes AppKit Fullscreen. Similar logic applies to fullscreen invoked by
an extension.
I accidentally changed this logic during the fullscreen refactor by removing
the 10.6 vs 10.7+ conditional. This CL adds back the conditional. I also
updated the code to explicitly indicate the mechanism that is invoking
fullscreen to prevent similar future mistakes.
BUG=NONE
Review URL: https://codereview.chromium.org/575653003
Cr-Commit-Position: refs/heads/master@{#295321}
The menu item "Enter Presentation Mode" has different effects in 10.6 and
10.7+. In 10.6, the menu item invokes Immersive Fullscreen. In 10.7+, the menu
item invokes AppKit Fullscreen. Similar logic applies to fullscreen invoked by
an extension.
I accidentally changed this logic during the fullscreen refactor by removing
the 10.6 vs 10.7+ conditional. This CL adds back the conditional. I also
updated the code to explicitly indicate the mechanism that is invoking
fullscreen to prevent similar future mistakes.
BUG=NONE
Review URL: https://codereview.chromium.org/575653003
Cr-Commit-Position: refs/heads/master@{#295321}