| commit | 502f69cc4cddffce39bbb4f8364465f0b26072a6 | |
| author | eakuefner <eakuefner@chromium.org> | |
| Thu, 6 Aug 2015 19:59:14 +0000 (6 12:59 -0700) | ||
| committer | Commit bot <commit-bot@chromium.org> | |
| Thu, 6 Aug 2015 20:00:21 +0000 (6 20:00 +0000) | ||
| tree | ef910e101b9a0b35f598b0e37057103abb84bdff | treesnapshot (tar.gz zip) |
| parent | 4862d06d330e014773f71c3d1cfce680ff44c237 | commitdiff |
[Telemetry] Refactor ResultsWrapperInterface to persist across runs.
We want to enable ResultsWrapperInterface instances to track custom state, as
we currently do in smoothness to ensure that all values added have the same IR.
This refactors ResultsWrapperInterface so that
timeline_based_measurement._TimelineBasedMetrics is responsible for setting the
label and results on a passed wrapper instance, rather than constructing a new
instance each time, to make this possible.
BUG=461101
R=nednguyen
TEST=tools/telemetry/run_tests web_perf; tools/perf/run_tests smoothness;
tools/perf/run_benchmark smoothness.top_25_smooth
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect
Review URL: https://codereview.chromium.org/1274943002
Cr-Commit-Position: refs/heads/master@{#342185}
We want to enable ResultsWrapperInterface instances to track custom state, as
we currently do in smoothness to ensure that all values added have the same IR.
This refactors ResultsWrapperInterface so that
timeline_based_measurement._TimelineBasedMetrics is responsible for setting the
label and results on a passed wrapper instance, rather than constructing a new
instance each time, to make this possible.
BUG=461101
R=nednguyen
TEST=tools/telemetry/run_tests web_perf; tools/perf/run_tests smoothness;
tools/perf/run_benchmark smoothness.top_25_smooth
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect
Review URL: https://codereview.chromium.org/1274943002
Cr-Commit-Position: refs/heads/master@{#342185}