| commit | 4fde2d1ddc037939360a430a6bd7a06eb8347cee | |
| author | ricea@chromium.org <ricea@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Tue, 1 Jul 2014 07:30:12 +0000 (1 07:30 +0000) | ||
| committer | ricea@chromium.org <ricea@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Tue, 1 Jul 2014 07:30:12 +0000 (1 07:30 +0000) | ||
| tree | e7eccbbf6b3337e45fb6cf2344d27302f87bf628 | treesnapshot (tar.gz zip) |
| parent | 98ab9c92414fc50a27199641b708b9f5a5ae93f2 | commitdiff |
Do not zero handed_out_sockets in FlushWithError
WebSocketTransportClientSocketPool::FlushWithError() was zeroing the
count of handed out sockets. Since these sockets belong to the various
ClientSocketHandles and not to the pool, we cannot make them go away in
FlushWithError(). Instead they are deleted when ReleaseSocket() is
called.
Also add a test to verify this behaviour.
TBR=jgraettinger@chromium.org
BUG=389116
TEST=net_unittests
Review URL: https://codereview.chromium.org/351393003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280776 0039d316-1c4b-4281-b951-d872f2087c98
WebSocketTransportClientSocketPool::FlushWithError() was zeroing the
count of handed out sockets. Since these sockets belong to the various
ClientSocketHandles and not to the pool, we cannot make them go away in
FlushWithError(). Instead they are deleted when ReleaseSocket() is
called.
Also add a test to verify this behaviour.
TBR=jgraettinger@chromium.org
BUG=389116
TEST=net_unittests
Review URL: https://codereview.chromium.org/351393003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280776 0039d316-1c4b-4281-b951-d872f2087c98
| net/socket/websocket_transport_client_socket_pool.cc | diffblobblamehistory | |
| net/socket/websocket_transport_client_socket_pool_unittest.cc | diffblobblamehistory |