| commit | 4f8c94a1175d6b388037c14f8fbc992146d6e6e9 | |
| author | shreyasv <shreyasv@chromium.org> | |
| Fri, 26 Jun 2015 22:59:46 +0000 (26 15:59 -0700) | ||
| committer | Commit bot <commit-bot@chromium.org> | |
| Fri, 26 Jun 2015 23:00:57 +0000 (26 23:00 +0000) | ||
| tree | 34a9d9d77e657771c2aab7cc1d63f7f7d10c2eae | treesnapshot (tar.gz zip) |
| parent | 05704e6d5fd196e86dcf1a4ca30c495a729f5ca1 | commitdiff |
Correcting a DCHECK.
The previous DCHECK was wrong since it was checking for |result|.
The base::JSONReader::Read API can return a nullptr base::Value.
Also moved the DCHECK outside the check for |handler| since it should be
verified even when no |handler| is registered.
BUG=503598
Review URL: https://codereview.chromium.org/1212393004
Cr-Commit-Position: refs/heads/master@{#336469}
The previous DCHECK was wrong since it was checking for |result|.
The base::JSONReader::Read API can return a nullptr base::Value.
Also moved the DCHECK outside the check for |handler| since it should be
verified even when no |handler| is registered.
BUG=503598
Review URL: https://codereview.chromium.org/1212393004
Cr-Commit-Position: refs/heads/master@{#336469}
| ios/web/web_state/ui/crw_web_controller.mm | diffblobblamehistory |