Fix failing (flaky) LayerTreeHostTestLCDNotification test.
commit4ea293f71923dd464e237f6ef581df22c625c695
authordanakj@chromium.org <danakj@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Wed, 13 Aug 2014 03:03:17 +0000 (13 03:03 +0000)
committerdanakj@chromium.org <danakj@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Wed, 13 Aug 2014 03:06:51 +0000 (13 03:06 +0000)
treea05083f79e4dd6d69514f8ea17815fc5153de6cf
parent4eebe74dc1fd6d3780180361f75707a6be33c3ce
Fix failing (flaky) LayerTreeHostTestLCDNotification test.

This test failed with impl-side painting because PictureLayer did not
skip commits caused by invalidating the layer during Update.

Meanwhile, this CL has some changes that changed the flaky failures
into always-failures. The change is to make the
ThreadProxy::CommitPendingForTesting check not only if a main frame is
in progress, but also if one will happen in the future. The failure was
flaky because the commit would be requested but not happen immediately
when impl-side painting was on due to activation (if the machine was
suitably loaded at the time). I renamed CommitPendingForTesting to
MainFrameWillHappenForTesting because "CommitPending" is a specific
notion in the public API of the scheduler and I didn't want to confuse
these two.

R=ajuma, brianderson, enne
BUG=402449, 397120

Review URL: https://codereview.chromium.org/462803002

Cr-Commit-Position: refs/heads/master@{#289165}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289165 0039d316-1c4b-4281-b951-d872f2087c98
15 files changed:
cc/layers/picture_layer.cc
cc/layers/texture_layer_unittest.cc
cc/scheduler/scheduler.h
cc/scheduler/scheduler_state_machine.cc
cc/scheduler/scheduler_state_machine.h
cc/test/fake_proxy.cc
cc/test/fake_proxy.h
cc/test/layer_tree_test.cc
cc/trees/layer_tree_host_unittest.cc
cc/trees/layer_tree_host_unittest_animation.cc
cc/trees/proxy.h
cc/trees/single_thread_proxy.cc
cc/trees/single_thread_proxy.h
cc/trees/thread_proxy.cc
cc/trees/thread_proxy.h