| commit | 4cac9b119cae33bf6277195cec857e97d7111690 | |
| author | sergeyv <sergeyv@chromium.org> | |
| Thu, 14 May 2015 14:18:25 +0000 (14 07:18 -0700) | ||
| committer | Commit bot <commit-bot@chromium.org> | |
| Thu, 14 May 2015 14:18:36 +0000 (14 14:18 +0000) | ||
| tree | f4e7e8c9820c5e89a22e4ffd2f467e36270a73f7 | treesnapshot (tar.gz zip) |
| parent | 845f198cd6e47f25d68355898fdff474796e2165 | commitdiff |
Revert of Add ETC1 powered SSE encoder for tile texture compression (patchset #23 id:440001 of https://codereview.chromium.org/1096703002/)
Reason for revert:
Speculative revert. Looks like this change breaks compilation on win8 GN:
http://build.chromium.org/p/chromium.win/builders/Win8%20GN
Failure Example:
http://build.chromium.org/p/chromium.win/builders/Win8%20GN/builds/7283
Original issue's description:
> Add ETC1 powered SSE encoder for tile texture compression
>
> Created an ETC1 encoder that uses SSE2 to improve compression speed.
> The SSE encoder extends TextureCompressor and uses the same algorithm as TextureCompressorETC1.
>
> Added unittest for TextureCompressorETC1.
>
> Moved shared code into a etc1 header.
>
> Added new performance test scenarios.
>
> Performance difference on Ubuntu x64, Haswell Processor:
> Without SSE:
> *RESULT Compress256x256BlackAndWhiteGradientImage: ETC1 Low= 1.966321587562561 us
> *RESULT Compress256x256SolidBlackImage: ETC1 Low= .0956009104847908 us
> *RESULT Compress256x256SolidColorImage: ETC1 Low= .4367307722568512 us
> *RESULT Compress256x256RandomColorImage: ETC1 Low= 5.948055744171143 us
>
> With SSE:
> *RESULT Compress256x256BlackAndWhiteGradientImage: ETC1 Low= 1.0316201448440552 us
> *RESULT Compress256x256SolidBlackImage: ETC1 Low= .25716209411621094 us
> *RESULT Compress256x256SolidColorImage: ETC1 Low= .2768038809299469 us
> *RESULT Compress256x256RandomColorImage: ETC1 Low= 1.834145426750183 us
>
> BUG=434699
> TEST=newly added unittest TextureCompressorETC1Test::Compress256x256CreateETC1, TextureCompressorETC1Test::Compress256x256RatioETC1
>
> Committed: https://crrev.com/5f3849aa8307399b7e6dfe5665ed149594244077
> Cr-Commit-Position: refs/heads/master@{#329840}
TBR=reveman@chromium.org,christiank@opera.com,jie.a.chen@intel.com,robert.bradford@intel.com,radu.velea@intel.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=434699
Review URL: https://codereview.chromium.org/1136083003
Cr-Commit-Position: refs/heads/master@{#329845}
Reason for revert:
Speculative revert. Looks like this change breaks compilation on win8 GN:
http://build.chromium.org/p/chromium.win/builders/Win8%20GN
Failure Example:
http://build.chromium.org/p/chromium.win/builders/Win8%20GN/builds/7283
Original issue's description:
> Add ETC1 powered SSE encoder for tile texture compression
>
> Created an ETC1 encoder that uses SSE2 to improve compression speed.
> The SSE encoder extends TextureCompressor and uses the same algorithm as TextureCompressorETC1.
>
> Added unittest for TextureCompressorETC1.
>
> Moved shared code into a etc1 header.
>
> Added new performance test scenarios.
>
> Performance difference on Ubuntu x64, Haswell Processor:
> Without SSE:
> *RESULT Compress256x256BlackAndWhiteGradientImage: ETC1 Low= 1.966321587562561 us
> *RESULT Compress256x256SolidBlackImage: ETC1 Low= .0956009104847908 us
> *RESULT Compress256x256SolidColorImage: ETC1 Low= .4367307722568512 us
> *RESULT Compress256x256RandomColorImage: ETC1 Low= 5.948055744171143 us
>
> With SSE:
> *RESULT Compress256x256BlackAndWhiteGradientImage: ETC1 Low= 1.0316201448440552 us
> *RESULT Compress256x256SolidBlackImage: ETC1 Low= .25716209411621094 us
> *RESULT Compress256x256SolidColorImage: ETC1 Low= .2768038809299469 us
> *RESULT Compress256x256RandomColorImage: ETC1 Low= 1.834145426750183 us
>
> BUG=434699
> TEST=newly added unittest TextureCompressorETC1Test::Compress256x256CreateETC1, TextureCompressorETC1Test::Compress256x256RatioETC1
>
> Committed: https://crrev.com/5f3849aa8307399b7e6dfe5665ed149594244077
> Cr-Commit-Position: refs/heads/master@{#329840}
TBR=reveman@chromium.org,christiank@opera.com,jie.a.chen@intel.com,robert.bradford@intel.com,radu.velea@intel.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=434699
Review URL: https://codereview.chromium.org/1136083003
Cr-Commit-Position: refs/heads/master@{#329845}