[Sync] Add size and crc32c to AttachmentId.
commit4c80a31653994ec6f112985b3493b1809e8e3415
authormaniscalco <maniscalco@chromium.org>
Wed, 11 Mar 2015 17:36:09 +0000 (11 10:36 -0700)
committerCommit bot <commit-bot@chromium.org>
Wed, 11 Mar 2015 17:37:21 +0000 (11 17:37 +0000)
treeb1faed3567b50465970a3e9ba2465e8d657b481f
parent416a5185e5026ad9e33718ed2fc006ac96bdfb5c
[Sync] Add size and crc32c to AttachmentId.

The purpose of this change is to ensure that if a client knows about an
attachment (i.e. has an AttachmentId or AttachmentIdProto) it will know
the attachment's size even if the attachment has never been available on
the local device.

The idea is that by storing size locally, we can simplify remote storage
management.

Move crc32c out of Attachment now that it's part of AttachmentId.

BUG=464431

Committed: https://crrev.com/23ae3128db0d84a6b1ffa640568a5ec90cfc8808
Cr-Commit-Position: refs/heads/master@{#319794}

Review URL: https://codereview.chromium.org/982883002

Cr-Commit-Position: refs/heads/master@{#320103}
28 files changed:
components/sync_driver/generic_change_processor_unittest.cc
sync/api/attachments/attachment.cc
sync/api/attachments/attachment.h
sync/api/attachments/attachment_id.cc
sync/api/attachments/attachment_id.h
sync/api/attachments/attachment_id_unittest.cc
sync/api/attachments/attachment_metadata.h
sync/api/attachments/attachment_metadata_unittest.cc
sync/api/attachments/attachment_unittest.cc
sync/api/sync_data_unittest.cc
sync/engine/directory_commit_contribution_unittest.cc
sync/engine/directory_update_handler_unittest.cc
sync/internal_api/attachments/attachment_downloader_impl.cc
sync/internal_api/attachments/attachment_downloader_impl_unittest.cc
sync/internal_api/attachments/attachment_service_impl_unittest.cc
sync/internal_api/attachments/attachment_store_test_template.h
sync/internal_api/attachments/attachment_uploader_impl_unittest.cc
sync/internal_api/attachments/fake_attachment_downloader.cc
sync/internal_api/attachments/fake_attachment_downloader_unittest.cc
sync/internal_api/attachments/on_disk_attachment_store.cc
sync/internal_api/attachments/on_disk_attachment_store_unittest.cc
sync/internal_api/public/attachments/attachment_downloader_impl.h
sync/internal_api/public/base/attachment_id_proto.cc
sync/internal_api/public/base/attachment_id_proto.h
sync/internal_api/public/base/attachment_id_proto_unittest.cc
sync/internal_api/sync_manager_impl_unittest.cc
sync/protocol/attachments.proto
sync/syncable/directory_unittest.cc