Have PNaCl use debug pexe URL instead of stripped pexe w/ kEnableNaClDebug
commit4b52e345067d0bd3a8b5bc20bc3439076eb4d0fd
authorjvoung@chromium.org <jvoung@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Fri, 28 Feb 2014 20:37:13 +0000 (28 20:37 +0000)
committerjvoung@chromium.org <jvoung@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Fri, 28 Feb 2014 20:37:13 +0000 (28 20:37 +0000)
tree7ff02756aa03a5c8c398a266897dee023441ab62
parent5fdc6fe2e5e85df1f441831ecac4baaf24f72fbf
Have PNaCl use debug pexe URL instead of stripped pexe w/ kEnableNaClDebug

Debug metadata is not part of the PNaCl stable bitcode format
so is stripped before deployment. In order to make debugging
easier (no separate translation), allow a separate debug URL
in the NMF file which can point to the unstripped
LLVM-formatted pexe which should still have debug metadata.

BUG= https://code.google.com/p/nativeclient/issues/detail?id=3765
TEST=browser_tests --gtest_filter=*PnaclDebugURL

Review URL: https://codereview.chromium.org/181153002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254212 0039d316-1c4b-4281-b951-d872f2087c98
16 files changed:
chrome/browser/chrome_content_browser_client.cc
chrome/test/data/nacl/nacl_test_data.gyp
chrome/test/data/nacl/pnacl_debug_url/pnacl_debug_url.html [new file with mode: 0644]
chrome/test/data/nacl/pnacl_debug_url/pnacl_has_debug.nmf [new file with mode: 0644]
chrome/test/data/nacl/pnacl_debug_url/pnacl_has_debug_flag_off.nmf [new file with mode: 0644]
chrome/test/data/nacl/pnacl_debug_url/pnacl_no_debug.nmf [new file with mode: 0644]
chrome/test/nacl/nacl_browsertest.cc
components/nacl/renderer/ppb_nacl_private_impl.cc
ppapi/api/private/ppb_nacl_private.idl
ppapi/c/private/ppb_nacl_private.h
ppapi/native_client/src/trusted/plugin/json_manifest.cc
ppapi/native_client/src/trusted/plugin/json_manifest.h
ppapi/native_client/src/trusted/plugin/plugin.cc
ppapi/native_client/src/trusted/plugin/pnacl_options.cc
ppapi/native_client/src/trusted/plugin/pnacl_options.h
ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c