| commit | 491236140c3f8226f2f89adbc61f246d3606145a | |
| author | pneubeck@chromium.org <pneubeck@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Thu, 14 Nov 2013 13:07:02 +0000 (14 13:07 +0000) | ||
| committer | pneubeck@chromium.org <pneubeck@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Thu, 14 Nov 2013 13:07:02 +0000 (14 13:07 +0000) | ||
| tree | 799c2f40f3edb49cae901b988355ebae0f6e49e7 | treesnapshot (tar.gz zip) |
| parent | 74e63cc6be735958c66da3857aef85827f6c6b10 | commitdiff |
ONC: Replace & by && and | by || in the Validator.
Bit-wise operators were used to more than one error/warning can be logged in one validation pass.
The downside of this was that using bit-wise operators for boolean logic frequently surprises readers who don't expect side-effects to be hidden within logical terms.
This replaces the bit-wise operators by their boolean counterparts for the sake of readability.
BUG=NONE
R=dconnelly@chromium.org
Review URL: https://codereview.chromium.org/72573002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235133 0039d316-1c4b-4281-b951-d872f2087c98
Bit-wise operators were used to more than one error/warning can be logged in one validation pass.
The downside of this was that using bit-wise operators for boolean logic frequently surprises readers who don't expect side-effects to be hidden within logical terms.
This replaces the bit-wise operators by their boolean counterparts for the sake of readability.
BUG=NONE
R=dconnelly@chromium.org
Review URL: https://codereview.chromium.org/72573002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235133 0039d316-1c4b-4281-b951-d872f2087c98
| chromeos/network/onc/onc_validator.cc | diffblobblamehistory |