Revert of GC plugin: consider references equal to raw pointers. (patchset #2 id:20001...
commit488237f4eee9244e536acf8c71570df691f66b27
authorthakis <thakis@chromium.org>
Fri, 7 Aug 2015 16:46:03 +0000 (7 09:46 -0700)
committerCommit bot <commit-bot@chromium.org>
Fri, 7 Aug 2015 16:46:43 +0000 (7 16:46 +0000)
treea1bf4cc5a1da83df7572b53b11882f23979dc4ca
parent4eb3411a6fadad9636dc2580bf1b316d00f621c6
Revert of GC plugin: consider references equal to raw pointers. (patchset #2 id:20001 of https://codereview.chromium.org/1274403002/ )

Reason for revert:
Turned the clang/win tot bots red: http://build.chromium.org/p/chromium.fyi/builders/ClangToTWin/builds/2327/steps/compile/logs/stdio

..\..\third_party\WebKit\Source\core/css/parser/CSSSupportsParser.h(13,1) :  error: [blink-gc] Class 'CSSSupportsParser' contains invalid fields.
class CSSSupportsParser {
^
..\..\third_party\WebKit\Source\core/css/parser/CSSSupportsParser.h(31,5) :  note: [blink-gc] Stack-allocated field 'm_parser' declared here:
    CSSParserImpl& m_parser;
    ^

Original issue's description:
> GC plugin: consider references equal to raw pointers.
>
> Unmanaged raw pointers to managed(GC) classes aren't safe across GCs,
> hence fields with raw pointer types to such GCed classes are identified
> and reported as errors or warnings.
>
> Extend that checking to also apply to reference pointer types.
>
> R=haraken
> BUG=420515
>
> Committed: https://crrev.com/70fe23896f81cd66ba1a205b0336f91c64e3fa4e
> Cr-Commit-Position: refs/heads/master@{#342320}

TBR=oilpan-reviews@chromium.org,sigbjornf@opera.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=420515

Review URL: https://codereview.chromium.org/1275383002

Cr-Commit-Position: refs/heads/master@{#342366}
tools/clang/blink_gc_plugin/BlinkGCPlugin.cpp
tools/clang/blink_gc_plugin/Edge.h
tools/clang/blink_gc_plugin/RecordInfo.cpp
tools/clang/blink_gc_plugin/tests/raw_ptr_to_gc_managed_class.h
tools/clang/blink_gc_plugin/tests/raw_ptr_to_gc_managed_class.txt