| commit | 43eb02c2ffcfa18adfcbf34cd0507a3d7494febe | |
| author | robliao <robliao@chromium.org> | |
| Fri, 27 Mar 2015 18:25:11 +0000 (27 11:25 -0700) | ||
| committer | Commit bot <commit-bot@chromium.org> | |
| Fri, 27 Mar 2015 18:26:01 +0000 (27 18:26 +0000) | ||
| tree | 97480dd6f2a973a6a187e71ad86aa77bea59de26 | treesnapshot (tar.gz zip) |
| parent | ddde1d3ec2c03222808b4d93a8c23208b3f4c2ff | commitdiff |
Refactor Uses of std::set to std::vector in SimpleFeature
Local profiling suggests that converting std::set to std::vector will save
around 10% of the overall startup time, likely due to the reduced allocs
involved with std::vector.
This change also reduces lookups by traversing the incoming dictionary
and iterating on the available values instead of looking through all
values for all features.
Finally, cleaned up and enforced the testing accessors via code and friend
declarations
BUG=460987
Review URL: https://codereview.chromium.org/1010973013
Cr-Commit-Position: refs/heads/master@{#322609}
Local profiling suggests that converting std::set to std::vector will save
around 10% of the overall startup time, likely due to the reduced allocs
involved with std::vector.
This change also reduces lookups by traversing the incoming dictionary
and iterating on the available values instead of looking through all
values for all features.
Finally, cleaned up and enforced the testing accessors via code and friend
declarations
BUG=460987
Review URL: https://codereview.chromium.org/1010973013
Cr-Commit-Position: refs/heads/master@{#322609}