[Android WebView] Limit synthesizing fake page loading events to popups
commit423c15f8067ac3701ffee25a1d306eab515bde67
authormnaganov <mnaganov@chromium.org>
Tue, 14 Apr 2015 10:27:35 +0000 (14 03:27 -0700)
committerCommit bot <commit-bot@chromium.org>
Tue, 14 Apr 2015 10:28:08 +0000 (14 10:28 +0000)
tree4f20192a0c8ffa485ec8471d287462ace15b53b6
parent0a3f5498e0a200298a4393b4b06f9876610499f6
[Android WebView] Limit synthesizing fake page loading events to popups

Only synthesize fake page loading events for popup windows.

This greatly simplifies our logic and eliminates false
positives that can inadvertently crash apps.

Also, add a test for the most commonly used scenario of
doing `loadUrl('javascript:...')` on a uncommitted load,
and rename tests to use shorter names.

BUG=458569,473586

Review URL: https://codereview.chromium.org/1087513002

Cr-Commit-Position: refs/heads/master@{#325023}
android_webview/java/src/org/chromium/android_webview/AwContents.java
android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegateAdapter.java
android_webview/java/src/org/chromium/android_webview/AwWebContentsObserver.java
android_webview/javatests/src/org/chromium/android_webview/test/AwTestBase.java
android_webview/javatests/src/org/chromium/android_webview/test/ClientOnPageFinishedTest.java
android_webview/javatests/src/org/chromium/android_webview/test/ClientOnReceivedError2Test.java