| commit | 40d81fd5fea87aa63e82f1875e5874315ab215cf | |
| author | bjornv <bjornv@chromium.org> | |
| Fri, 24 Apr 2015 09:09:15 +0000 (24 02:09 -0700) | ||
| committer | Commit bot <commit-bot@chromium.org> | |
| Fri, 24 Apr 2015 09:09:34 +0000 (24 09:09 +0000) | ||
| tree | f0a7e89d443807428e58f2b52b427ab3bfc2fbd3 | treesnapshot (tar.gz zip) |
| parent | c6f2f80dfb217d42ffe7e28ea26fb4e0d2a5459f | commitdiff |
[media_stream_audio_processor] Avoids updating UMA stats before AEC has valid results
Stats are updated and logged continuously when echo cancellation is enabled. Being enabled is no guarantee for actually running since it, for example, is enabled by default when opening the microphone.
All these invalid data clutter the UMA histogram.
The improvement is a check for the first frame containing an echo state before start logging. This can only happen when the echo cancellation is actually running.
BUG=450193
Review URL: https://codereview.chromium.org/1081063003
Cr-Commit-Position: refs/heads/master@{#326761}
Stats are updated and logged continuously when echo cancellation is enabled. Being enabled is no guarantee for actually running since it, for example, is enabled by default when opening the microphone.
All these invalid data clutter the UMA histogram.
The improvement is a check for the first frame containing an echo state before start logging. This can only happen when the echo cancellation is actually running.
BUG=450193
Review URL: https://codereview.chromium.org/1081063003
Cr-Commit-Position: refs/heads/master@{#326761}
| content/renderer/media/media_stream_audio_processor_options.cc | diffblobblamehistory | |
| content/renderer/media/media_stream_audio_processor_options.h | diffblobblamehistory |